Add packer/unpacker default factory methods

xerial · xerial · commit 4f87db3d1e37 · 2014-08-04T10:30:22.000+09:00
diff --git a/msgpack-core/src/main/java/org/msgpack/core/MessagePackFactory.java b/msgpack-core/src/main/java/org/msgpack/core/MessagePackFactory.java
@@ -32,6 +32,26 @@ public static MessagePacker newDefaultPacker(OutputStream out) {
         return DEFAULT.newPacker(out);
     }
 
+    public static MessagePacker newDefaultPacker(WritableByteChannel channel) {
+        return DEFAULT.newPacker(channel);
+    }
+
+    public static MessageUnpacker newDefaultUnpacker(InputStream in) {
+        return DEFAULT.newUnpacker(in);
+    }
+
+    public static MessageUnpacker newDefaultUnpacker(ReadableByteChannel channel) {
+        return DEFAULT.newUnpacker(channel);
+    }
+
+    public static MessageUnpacker newDefaultUnpacker(byte[] arr) {
+        return DEFAULT.newUnpacker(arr);
+    }
+
+    public static MessageUnpacker newDefaultUnpacker(byte[] arr, int offset, int length) {
+        return DEFAULT.newUnpacker(arr, offset, length);
+    }
+
 
     /**
      * Create an MessagePacker that outputs the packed data to the specified stream
diff --git a/msgpack-core/src/test/scala/org/msgpack/core/MessageUnpackerTest.scala b/msgpack-core/src/test/scala/org/msgpack/core/MessageUnpackerTest.scala
@@ -508,14 +508,25 @@ class MessageUnpackerTest extends MessagePackSpec {
 
       val data2 = intSeq
       val b2 = createMessagePackData(packer => data2 foreach packer.packInt)
-      unpacker.reset(new ArrayBufferInput(b2))
+      val bi = new ArrayBufferInput(b2)
+      unpacker.reset(bi)
       val unpacked2 = Array.newBuilder[Int]
       while(unpacker.hasNext) {
         unpacked2 += unpacker.unpackInt()
       }
       unpacker.close
       unpacked2.result shouldBe data2
 
+      // reused the buffer input instance
+      bi.reset(b2)
+      unpacker.reset(bi)
+      val unpacked3 = Array.newBuilder[Int]
+      while(unpacker.hasNext) {
+        unpacked3 += unpacker.unpackInt()
+      }
+      unpacker.close
+      unpacked3.result shouldBe data2
+
     }
 
   }
