msgpack#127 Add a performance test for OutputStremBufferOutput.reset

xerial · xerial · commit 14adad23683c · 2014-07-28T11:54:53.000+09:00
diff --git a/msgpack-core/src/main/java/org/msgpack/core/MessagePackFactory.java b/msgpack-core/src/main/java/org/msgpack/core/MessagePackFactory.java
@@ -27,6 +27,12 @@ public MessagePackFactory(MessagePack.Config config) {
      */
     public static final MessagePackFactory DEFAULT = new MessagePackFactory(MessagePack.DEFAULT_CONFIG);
 
+
+    public static MessagePacker newDefaultPacker(OutputStream out) {
+        return DEFAULT.newPacker(out);
+    }
+
+
     /**
      * Create an MessagePacker that outputs the packed data to the specified stream
      * @param out
diff --git a/msgpack-core/src/test/scala/org/msgpack/core/MessagePackerTest.scala b/msgpack-core/src/test/scala/org/msgpack/core/MessagePackerTest.scala
@@ -3,6 +3,7 @@ package org.msgpack.core
 import java.io.ByteArrayOutputStream
 
 import org.msgpack.core.buffer.{OutputStreamBufferOutput, ArrayBufferInput}
+import xerial.core.io.IOUtil
 
 import scala.util.Random
 
@@ -11,7 +12,7 @@ import scala.util.Random
  */
 class MessagePackerTest extends MessagePackSpec {
 
-  val mf = MessagePackFactory.DEFAULT;
+  val mf = MessagePackFactory.DEFAULT
 
   def verifyIntSeq(answer:Array[Int], packed:Array[Byte]) {
     val unpacker = mf.newUnpacker(packed)
@@ -50,5 +51,41 @@ class MessagePackerTest extends MessagePackSpec {
       verifyIntSeq(intSeq3, b3.toByteArray)
     }
 
+    "improve the performance via reset method" taggedAs("reset") in {
+
+
+      val N = 1000
+      val t = time("packer", repeat = 10) {
+        block("no-buffer-reset") {
+          val out = new ByteArrayOutputStream
+          IOUtil.withResource(MessagePackFactory.newDefaultPacker(out)) { packer =>
+            for (i <- 0 until N) {
+              val outputStream = new ByteArrayOutputStream()
+              packer.reset(new OutputStreamBufferOutput(outputStream))
+              packer.packInt(0)
+              packer.flush()
+            }
+          }
+        }
+
+        block("buffer-reset") {
+          val out = new ByteArrayOutputStream
+          IOUtil.withResource(MessagePackFactory.newDefaultPacker(out)) { packer =>
+            val bufferOut = new OutputStreamBufferOutput(new ByteArrayOutputStream())
+            for (i <- 0 until N) {
+              val outputStream = new ByteArrayOutputStream()
+              bufferOut.reset(outputStream)
+              packer.reset(bufferOut)
+              packer.packInt(0)
+              packer.flush()
+            }
+          }
+        }
+      }
+
+      t("buffer-reset").averageWithoutMinMax should be <= t("no-buffer-reset").averageWithoutMinMax
+
+    }
+
   }
 }
