sof: Avoid comparison with NULL

Sam Muhammed · dbaluta · commit de085f22f55a · 2020-04-07T12:07:59.000+03:00
Use (!x) instead of comparison with NULL.

Signed-off-by: Sam Muhammed &lt;jane.pnx9@gmail.com&gt;
diff --git a/src/debug/gdb/gdb.c b/src/debug/gdb/gdb.c
@@ -445,7 +445,7 @@ static unsigned char *mem_to_hex(void *mem_, unsigned char *buf,
 	unsigned char *mem = mem_;
 	unsigned char ch;
 
-	if ((mem == NULL) || (buf == NULL))
+	if (!mem || !buf)
 		return NULL;
 	while (count-- > 0) {
 		ch = arch_gdb_load_from_memory(mem);
@@ -468,7 +468,7 @@ static unsigned char *hex_to_mem(const unsigned char *buf, void *mem_,
 	int i;
 	unsigned char ch;
 
-	if ((mem == NULL) || (buf == NULL))
+	if (!mem || !buf)
 		return NULL;
 	for (i = 0; i < count; i++) {
 		ch = get_hex(*buf++) << 4;
diff --git a/src/ipc/dma-copy.c b/src/ipc/dma-copy.c
@@ -137,7 +137,7 @@ int dma_copy_new(struct dma_copy *dc)
 	dev = DMA_DEV_HOST;
 	cap = 0;
 	dc->dmac = dma_get(dir, cap, dev, DMA_ACCESS_SHARED);
-	if (dc->dmac == NULL) {
+	if (!dc->dmac) {
 		trace_dma_error("dma_copy_new(): dc->dmac = NULL");
 		return -ENODEV;
 	}
diff --git a/src/ipc/handler.c b/src/ipc/handler.c
@@ -239,7 +239,7 @@ static int ipc_stream_pcm_params(uint32_t stream)
 	trace_ipc("ipc: comp %d -> params", pcm_params.comp_id);
 
 	/* sanity check comp */
-	if (pcm_dev->cd->pipeline == NULL) {
+	if (!pcm_dev->cd->pipeline) {
 		trace_ipc_error("ipc: comp %d pipeline not found",
 				pcm_params.comp_id);
 		return -EINVAL;
@@ -357,7 +357,7 @@ static int ipc_stream_pcm_free(uint32_t header)
 	trace_ipc("ipc: comp %d -> free", free_req.comp_id);
 
 	/* sanity check comp */
-	if (pcm_dev->cd->pipeline == NULL) {
+	if (!pcm_dev->cd->pipeline) {
 		trace_ipc_error("ipc: comp %d pipeline not found",
 				free_req.comp_id);
 		return -EINVAL;
diff --git a/test/cmocka/src/list/list_item_append.c b/test/cmocka/src/list/list_item_append.c
@@ -30,9 +30,8 @@ static int setup(void **state)
 	data->tail_minus_1 = malloc(sizeof(struct list_item));
 	data->tail = malloc(sizeof(struct list_item));
 
-	if (data->head == NULL
-			|| data->tail_minus_1 == NULL
-			|| data->tail == NULL) {
+	if (!data->head || !data->tail_minus_1
+			|| !data->tail) {
 		free(data->head);
 		free(data->tail_minus_1);
 		free(data->tail);
diff --git a/test/cmocka/src/list/list_item_del.c b/test/cmocka/src/list/list_item_del.c
@@ -30,9 +30,8 @@ static int setup(void **state)
 	data->tail_minus_1 = malloc(sizeof(struct list_item));
 	data->tail = malloc(sizeof(struct list_item));
 
-	if (data->head == NULL
-			|| data->tail_minus_1 == NULL
-			|| data->tail == NULL) {
+	if (!data->head	|| !data->tail_minus_1
+			|| !data->tail) {
 		free(data->head);
 		free(data->tail_minus_1);
 		free(data->tail);
diff --git a/test/cmocka/src/list/list_item_is_last.c b/test/cmocka/src/list/list_item_is_last.c
@@ -30,9 +30,8 @@ static int setup(void **state)
 	data->tail_minus_1 = malloc(sizeof(struct list_item));
 	data->tail = malloc(sizeof(struct list_item));
 
-	if (data->head == NULL
-			|| data->tail_minus_1 == NULL
-			|| data->tail == NULL) {
+	if (!data->head	|| !data->tail_minus_1
+			|| !data->tail) {
 		free(data->head);
 		free(data->tail_minus_1);
 		free(data->tail);
diff --git a/test/cmocka/src/list/list_item_prepend.c b/test/cmocka/src/list/list_item_prepend.c
@@ -30,9 +30,8 @@ static int setup(void **state)
 	data->tail_minus_1 = malloc(sizeof(struct list_item));
 	data->tail = malloc(sizeof(struct list_item));
 
-	if (data->head == NULL
-			|| data->tail_minus_1 == NULL
-			|| data->tail == NULL) {
+	if (!data->head	|| !data->tail_minus_1
+			|| !data->tail) {
 		free(data->head);
 		free(data->tail_minus_1);
 		free(data->tail);

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ int dma_copy_new(struct dma_copy *dc)`
`137`	`137`	`dev = DMA_DEV_HOST;`
`138`	`138`	`cap = 0;`
`139`	`139`	`dc->dmac = dma_get(dir, cap, dev, DMA_ACCESS_SHARED);`
`140`		`- if (dc->dmac == NULL) {`
	`140`	`+ if (!dc->dmac) {`
`141`	`141`	`trace_dma_error("dma_copy_new(): dc->dmac = NULL");`
`142`	`142`	`return -ENODEV;`
`143`	`143`	`}`