Skip to content

Commit fd9f6d4

Browse files
jshajsha
committed
Menu improvements
Add missing `checkbox` class back to menu items, restoring the check marks and x's. Also, add a 'View All Rules' link in the menu to visit the Atlas.
1 parent ba5bf5d commit fd9f6d4

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+52
-0
lines changed

‎src/chrome/content/code/ApplicableList.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,7 @@ ApplicableList.prototype = {
228228
var item = this.document.createElement('menuitem');
229229
item.setAttribute('command', rule.id+'-command');
230230
item.setAttribute('class', type+'-item menuitem-iconic');
231+
item.setAttribute('type', 'checkbox');
231232
item.setAttribute('label', rule.name);
232233

233234
// we can get confused if rulesets have their state changed after the

‎src/chrome/content/toolbar_button.xul‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@
4545
<menuseparator class="hide-on-disable"/>
4646
<menuitem label="&https-everywhere.prefs.reset_defaults;"
4747
command="https-everywhere-menuitem-resetToDefaults" class="hide-on-disable"/>
48+
<menuitem label="&https-everywhere.menu.viewAllRules;"
49+
command="https-everywhere-menuitem-viewAllRules" class="hide-on-disable" />
4850
<menuitem type="checkbox" id="http-nowhere-item" label="&https-everywhere.menu.blockHttpRequests;"
4951
oncommand="httpsEverywhere.toolbarButton.toggleHttpNowhere()" class="hide-on-disable"/>
5052
<menuseparator class="hide-on-disable"/>
@@ -63,6 +65,8 @@
6365
oncommand="httpsEverywhere.toolbarButton.resetToDefaults()" />
6466
<command id="https-everywhere-menuitem-globalEnableToggle"
6567
oncommand="toggleEnabledState();" />
68+
<command id="https-everywhere-menuitem-viewAllRules"
69+
oncommand="open_in_tab('https://www.eff.org/https-everywhere/atlas/');" />
6670
<command id="https-everywhere-menuitem-about"
6771
oncommand="HTTPSEverywhere.chrome_opener('chrome://https-everywhere/content/about.xul');" />
6872
<command id="https-everywhere-menuitem-observatory"

‎src/chrome/locale/ar/https-everywhere.dtd‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,3 +47,4 @@
4747
<!ENTITY https-everywhere.ruleset-tests.status_title "اختبارات مجموعة أوامر HTTPS Everywhere">
4848
<!ENTITY https-everywhere.ruleset-tests.status_cancel_button "إلغاء">
4949
<!ENTITY https-everywhere.ruleset-tests.status_start_button "ابدأ">
50+
<!ENTITY https-everywhere.menu.viewAllRules "View All Rules">

‎src/chrome/locale/bg/https-everywhere.dtd‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,3 +47,4 @@
4747
<!ENTITY https-everywhere.ruleset-tests.status_title "Тестване правилата на HTTPS Everywhere">
4848
<!ENTITY https-everywhere.ruleset-tests.status_cancel_button "Отказ">
4949
<!ENTITY https-everywhere.ruleset-tests.status_start_button "Старт">
50+
<!ENTITY https-everywhere.menu.viewAllRules "View All Rules">

‎src/chrome/locale/ca/https-everywhere.dtd‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,3 +47,4 @@
4747
<!ENTITY https-everywhere.ruleset-tests.status_title "HTTPS Everywhere test de funcionament">
4848
<!ENTITY https-everywhere.ruleset-tests.status_cancel_button "Cancel·la">
4949
<!ENTITY https-everywhere.ruleset-tests.status_start_button "Inici">
50+
<!ENTITY https-everywhere.menu.viewAllRules "View All Rules">

‎src/chrome/locale/cs/https-everywhere.dtd‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,3 +47,4 @@
4747
<!ENTITY https-everywhere.ruleset-tests.status_title "Test pravidel HTTPS Everywhere">
4848
<!ENTITY https-everywhere.ruleset-tests.status_cancel_button "Zrušit">
4949
<!ENTITY https-everywhere.ruleset-tests.status_start_button "Zapnout">
50+
<!ENTITY https-everywhere.menu.viewAllRules "View All Rules">

‎src/chrome/locale/da/https-everywhere.dtd‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,3 +47,4 @@
4747
<!ENTITY https-everywhere.ruleset-tests.status_title "Afprøvninger af HTTPS Overalt-regelsæt">
4848
<!ENTITY https-everywhere.ruleset-tests.status_cancel_button "Annullér">
4949
<!ENTITY https-everywhere.ruleset-tests.status_start_button "Start">
50+
<!ENTITY https-everywhere.menu.viewAllRules "View All Rules">

‎src/chrome/locale/de/https-everywhere.dtd‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,3 +47,4 @@
4747
<!ENTITY https-everywhere.ruleset-tests.status_title "HTTPS-Everywhere-Regelsatztests">
4848
<!ENTITY https-everywhere.ruleset-tests.status_cancel_button "Abbrechen">
4949
<!ENTITY https-everywhere.ruleset-tests.status_start_button "Start">
50+
<!ENTITY https-everywhere.menu.viewAllRules "View All Rules">

‎src/chrome/locale/el/https-everywhere.dtd‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,3 +47,4 @@
4747
<!ENTITY https-everywhere.ruleset-tests.status_title "HTTPS Everywhere Δοκιμές Κανόνων">
4848
<!ENTITY https-everywhere.ruleset-tests.status_cancel_button "Ακύρωση">
4949
<!ENTITY https-everywhere.ruleset-tests.status_start_button "Εκκίνηση">
50+
<!ENTITY https-everywhere.menu.viewAllRules "View All Rules">

‎src/chrome/locale/en/https-everywhere.dtd‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
<!ENTITY https-everywhere.menu.globalDisable "Disable HTTPS Everywhere">
1818
<!ENTITY https-everywhere.menu.blockHttpRequests "Block all HTTP requests">
1919
<!ENTITY https-everywhere.menu.showCounter "Show Counter">
20+
<!ENTITY https-everywhere.menu.viewAllRules "View All Rules">
2021

2122
<!ENTITY https-everywhere.prefs.title "HTTPS Everywhere Preferences">
2223
<!ENTITY https-everywhere.prefs.enable_all "Enable All">

0 commit comments

Comments
 (0)