Make basic preferences dialogs resizable

Sujit Rao · pde · commit ce3b47a1209b · 2012-01-09T14:58:55.000-05:00
diff --git a/src/chrome/content/observatory-preferences.xul b/src/chrome/content/observatory-preferences.xul
@@ -11,7 +11,7 @@
   title="&ssl-observatory.prefs.title;"
   width="800"
   height="768"
-  persist="screenX screenY"
+  persist="screenX screenY width height"
   onload="observatory_prefs_init(document)"
   ondialogaccept="observatory_prefs_accept()">
   <script type="application/x-javascript" src="observatory-xul.js" />
diff --git a/src/chrome/content/preferences.xul b/src/chrome/content/preferences.xul
@@ -13,7 +13,7 @@
         buttonlabelextra2="&https-everywhere.prefs.reset_defaults;"
         ondialogextra2="reset_defaults();"
         title="&https-everywhere.prefs.title;"
-        persist="screenX screenY"
+        persist="screenX screenY width height"
         onload="https_prefs_init(document)"
         ondialogaccept="https_prefs_accept()">
 
diff --git a/src/chrome/content/toolbar_button.xul b/src/chrome/content/toolbar_button.xul
@@ -50,11 +50,11 @@
     <command id="https-everywhere-menuitem-globalEnableToggle"
       oncommand="toggleEnabledState();" />
     <command id="https-everywhere-menuitem-preferences"
-      oncommand="HTTPSEverywhere.chrome_opener('chrome://https-everywhere/content/preferences.xul');" />
+      oncommand="HTTPSEverywhere.chrome_opener('chrome://https-everywhere/content/preferences.xul', 'chrome,centerscreen,resizable=yes');" />
     <command id="https-everywhere-menuitem-about"
       oncommand="HTTPSEverywhere.chrome_opener('chrome://https-everywhere/content/about.xul');" />
     <command id="https-everywhere-menuitem-observatory"
-      oncommand="HTTPSEverywhere.chrome_opener('chrome://https-everywhere/content/observatory-preferences.xul');" />
+      oncommand="HTTPSEverywhere.chrome_opener('chrome://https-everywhere/content/observatory-preferences.xul', 'chrome,centerscreen,resizable=yes');" />
     <command id="https-everywhere-menuitem-donate-eff" 
       oncommand="open_in_tab('https://www.eff.org/donate');" />
     <command id="https-everywhere-menuitem-donate-tor" 
diff --git a/src/components/https-everywhere.js b/src/components/https-everywhere.js
@@ -621,13 +621,14 @@ HTTPSEverywhere.prototype = {
     }
   },
 
-  chrome_opener: function(uri) {
+  chrome_opener: function(uri, args) {
     // we don't use window.open, because we need to work around TorButton's 
     // state control
+    args = args || 'chrome,centerscreen';
     return CC['@mozilla.org/appshell/window-mediator;1']
       .getService(CI.nsIWindowMediator) 
       .getMostRecentWindow('navigator:browser')
-      .open(uri,'', 'chrome,centerscreen' );
+      .open(uri,'', args );
   },
 
   toggleEnabledState: function() {
