Skip to content

Commit 0ae2ffe

Browse files
committed
fix: move gRPC dependencies to an extra
PR feast-dev#3687 added a spiffy feature to ingest streaming features, but this came along with a large batch of depdencies. Notable this induces a core dependency on `protobuf>=4.21.6` while Feast itself is on `protobuf<4.23.4,>3.20`. This is a fiddly narrow range and excludes all 3.x uses. Signed-off-by: Chris Burroughs <chris.burroughs@gmail.com>
1 parent 86d6221 commit 0ae2ffe

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

setup.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,6 @@
4545
"colorama>=0.3.9,<1",
4646
"dill~=0.3.0",
4747
"fastavro>=1.1.0,<2",
48-
"grpcio>=1.56.2,<2",
49-
"grpcio-tools>=1.56.2,<2",
50-
"grpcio-reflection>=1.56.2,<2",
51-
"grpcio-health-checking>=1.56.2,<2",
5248
"mypy-protobuf==3.1",
5349
"Jinja2>=2,<4",
5450
"jsonschema",
@@ -144,6 +140,14 @@
144140
"hazelcast-python-client>=5.1",
145141
]
146142

143+
144+
GRPCIO_REQUIRED = [
145+
"grpcio>=1.56.2,<2",
146+
"grpcio-tools>=1.56.2,<2",
147+
"grpcio-reflection>=1.56.2,<2",
148+
"grpcio-health-checking>=1.56.2,<2",
149+
]
150+
147151
CI_REQUIRED = (
148152
[
149153
"build",
@@ -202,6 +206,7 @@
202206
+ AZURE_REQUIRED
203207
+ ROCKSET_REQUIRED
204208
+ HAZELCAST_REQUIRED
209+
+ GRPCIO_REQUIRED
205210
)
206211

207212

@@ -368,6 +373,7 @@ def run(self):
368373
"docs": DOCS_REQUIRED,
369374
"cassandra": CASSANDRA_REQUIRED,
370375
"hazelcast": HAZELCAST_REQUIRED,
376+
"grpcio": GRPCIO_REQUIRED,
371377
"rockset": ROCKSET_REQUIRED,
372378
},
373379
include_package_data=True,

0 commit comments

Comments
 (0)