keyString for SecretKey must be encoded

jaeggir · fernandezpablo85 · commit 959c093620fe · 2010-11-30T14:10:57.000-03:00
diff --git a/src/main/java/org/scribe/services/HMACSha1SignatureService.java b/src/main/java/org/scribe/services/HMACSha1SignatureService.java
@@ -30,7 +30,7 @@ public String getSignature(String baseString, String apiSecret, String tokenSecr
     {
       Preconditions.checkEmptyString(baseString, "Base string cant be null or empty string");
       Preconditions.checkEmptyString(apiSecret, "Api secret cant be null or empty string");
-      return doSign(baseString, apiSecret + '&' + tokenSecret);
+      return doSign(baseString, URLUtils.percentEncode(apiSecret) + '&' + URLUtils.percentEncode(tokenSecret));
     } 
     catch (Exception e)
     {

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public String getSignature(String baseString, String apiSecret, String tokenSecr`
`30`	`30`	`{`
`31`	`31`	`Preconditions.checkEmptyString(baseString, "Base string cant be null or empty string");`
`32`	`32`	`Preconditions.checkEmptyString(apiSecret, "Api secret cant be null or empty string");`
`33`		`- return doSign(baseString, apiSecret + '&' + tokenSecret);`
	`33`	`+ return doSign(baseString, URLUtils.percentEncode(apiSecret) + '&' + URLUtils.percentEncode(tokenSecret));`
`34`	`34`	`}`
`35`	`35`	`catch (Exception e)`
`36`	`36`	`{`