implement async HTTPClient methods in JDKHttpClient (it's complete now)

kullfar · kullfar · commit c9bb1a1c4c99 · 2017-01-11T15:45:02.000+03:00
diff --git a/scribejava-core/src/main/java/com/github/scribejava/core/httpclient/jdk/JDKHttpClient.java b/scribejava-core/src/main/java/com/github/scribejava/core/httpclient/jdk/JDKHttpClient.java
@@ -34,21 +34,35 @@ public void close() throws IOException {
     public <T> Future<T> executeAsync(String userAgent, Map<String, String> headers, Verb httpVerb, String completeUrl,
             byte[] bodyContents, OAuthAsyncRequestCallback<T> callback,
             OAuthRequestAsync.ResponseConverter<T> converter) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        try {
+            final T response = converter.convert(execute(userAgent, headers, httpVerb, completeUrl, bodyContents));
+            callback.onCompleted(response);
+            return new JDKHttpFuture<>(response);
+        } catch (InterruptedException | ExecutionException | IOException e) {
+            callback.onThrowable(e);
+            return new JDKHttpFuture<>(e);
+        }
     }
 
     @Override
     public <T> Future<T> executeAsync(String userAgent, Map<String, String> headers, Verb httpVerb, String completeUrl,
             String bodyContents, OAuthAsyncRequestCallback<T> callback,
             OAuthRequestAsync.ResponseConverter<T> converter) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        try {
+            final T response = converter.convert(execute(userAgent, headers, httpVerb, completeUrl, bodyContents));
+            callback.onCompleted(response);
+            return new JDKHttpFuture<>(response);
+        } catch (InterruptedException | ExecutionException | IOException e) {
+            callback.onThrowable(e);
+            return new JDKHttpFuture<>(e);
+        }
     }
 
     @Override
     public <T> Future<T> executeAsync(String userAgent, Map<String, String> headers, Verb httpVerb, String completeUrl,
             File bodyContents, OAuthAsyncRequestCallback<T> callback,
             OAuthRequestAsync.ResponseConverter<T> converter) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        throw new UnsupportedOperationException("JDKHttpClient do not support File payload for the moment");
     }
 
     @Override
diff --git a/scribejava-core/src/main/java/com/github/scribejava/core/httpclient/jdk/JDKHttpFuture.java b/scribejava-core/src/main/java/com/github/scribejava/core/httpclient/jdk/JDKHttpFuture.java
@@ -0,0 +1,54 @@
+package com.github.scribejava.core.httpclient.jdk;
+
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+public class JDKHttpFuture<V> implements Future<V> {
+
+    private final Exception exception;
+    private final V response;
+
+    public JDKHttpFuture(Exception exception) {
+        this(null, exception);
+    }
+
+    public JDKHttpFuture(V response) {
+        this(response, null);
+    }
+
+    private JDKHttpFuture(V response, Exception exception) {
+        this.response = response;
+        this.exception = exception;
+    }
+
+    @Override
+    public boolean cancel(boolean mayInterruptIfRunning) {
+        return false;
+    }
+
+    @Override
+    public boolean isCancelled() {
+        return false;
+    }
+
+    @Override
+    public boolean isDone() {
+        return true;
+    }
+
+    @Override
+    public V get() throws InterruptedException, ExecutionException {
+        if (exception != null) {
+            throw new ExecutionException(exception);
+        }
+
+        return response;
+    }
+
+    @Override
+    public V get(long timeout, TimeUnit unit) throws InterruptedException, ExecutionException, TimeoutException {
+        return get();
+    }
+}
