issue scribejava#753

vivin · vivin · commit a2887ddc0d72 · 2017-04-05T19:54:59.000-07:00
Makes `addOAuthParams` and `appendSignature` `protected`, so that they can be used from overridden `prepareRequestTokenRequest` methods in subclasses. This makes it possible to deal with the (rare) case where the request-token endpoint in an OAuth 1.0a service accepts additional-parameters; these are supported by request-token endpoints as per the specification.
diff --git a/scribejava-core/src/main/java/com/github/scribejava/core/oauth/OAuth10aService.java b/scribejava-core/src/main/java/com/github/scribejava/core/oauth/OAuth10aService.java
@@ -75,7 +75,7 @@ protected OAuthRequest prepareRequestTokenRequest() {
         return request;
     }
 
-    private void addOAuthParams(OAuthRequest request, String tokenSecret) {
+    protected void addOAuthParams(OAuthRequest request, String tokenSecret) {
         final OAuthConfig config = getConfig();
         request.addOAuthParameter(OAuthConstants.TIMESTAMP, api.getTimestampService().getTimestampInSeconds());
         request.addOAuthParameter(OAuthConstants.NONCE, api.getTimestampService().getNonce());
@@ -177,7 +177,7 @@ private String getSignature(OAuthRequest request, String tokenSecret) {
         return signature;
     }
 
-    private void appendSignature(OAuthRequest request) {
+    protected void appendSignature(OAuthRequest request) {
         final OAuthConfig config = getConfig();
         switch (config.getSignatureType()) {
             case Header:
