automatic conversion to object for add_property()

dabrahams · dabrahams · commit 0b33d1800d05 · 2002-08-23T04:15:37.000Z
[SVN r15065]
diff --git a/include/boost/python/class.hpp b/include/boost/python/class.hpp
@@ -230,8 +230,19 @@ class class_ : public objects::class_base
     }
 
     // Property creation
-    self& add_property(char const* name, object const& fget);
-    self& add_property(char const* name, object const& fget, object const& fset);
+    template <class Get>
+    self& add_property(char const* name, Get const& fget)
+    {
+        base::add_property(name, object(fget));
+        return *this;
+    }
+    
+    template <class Get, class Set>
+    self& add_property(char const* name, Get const& fget, Set const& fset)
+    {
+        base::add_property(name, object(fget), object(fset));
+        return *this;
+    }
 
     template <class U>
     self& setattr(char const* name, U const& x)
@@ -367,20 +378,6 @@ inline class_<T,X1,X2,X3>::class_(char const* name, char const* doc, no_init_t)
     this->def_no_init();
 }
 
-template <class T, class X1, class X2, class X3>
-inline class_<T,X1,X2,X3>& class_<T,X1,X2,X3>::add_property(char const* name, object const& fget)
-{
-    base::add_property(name, fget);
-    return *this;
-}
-
-template <class T, class X1, class X2, class X3>
-inline class_<T,X1,X2,X3>& class_<T,X1,X2,X3>::add_property(char const* name, object const& fget, object const& fset)
-{
-    base::add_property(name, fget, fset);
-    return *this;
-}
-
 namespace detail
 {
   // This is an mpl BinaryMetaFunction object with a runtime behavior,
diff --git a/test/data_members.cpp b/test/data_members.cpp
@@ -26,7 +26,7 @@ BOOST_PYTHON_MODULE_INIT(data_members_ext)
         .def("value", &X::value)
         .def("set", &X::set)
         .def_readonly("x", &X::x)
-        .add_property("get_fair_value", object(&get_fair_value))
+        .add_property("fair_value", &get_fair_value)
         ;
     
     class_<Y>("Y", args<int>())
diff --git a/test/data_members.py b/test/data_members.py
@@ -7,6 +7,9 @@
 ... except AttributeError: pass
 ... else: print 'no error'
 
+>>> x.fair_value
+42.0
+
 >>> y = Y(69)
 >>> y.x
 69

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ BOOST_PYTHON_MODULE_INIT(data_members_ext)`
`26`	`26`	`.def("value", &X::value)`
`27`	`27`	`.def("set", &X::set)`
`28`	`28`	`.def_readonly("x", &X::x)`
`29`		`- .add_property("get_fair_value", object(&get_fair_value))`
	`29`	`+ .add_property("fair_value", &get_fair_value)`
`30`	`30`	`;`
`31`	`31`
`32`	`32`	`class_<Y>("Y", args<int>())`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,9 @@`
`7`	`7`	`... except AttributeError: pass`
`8`	`8`	`... else: print 'no error'`
`9`	`9`
	`10`	`+>>> x.fair_value`
	`11`	`+42.0`
	`12`	`+`
`10`	`13`	`>>> y = Y(69)`
`11`	`14`	`>>> y.x`
`12`	`15`	`69`