branch name is given as a script parameter#8
Closed
cypreess wants to merge 4 commits into
Closed
Conversation
| Flask | ||
| ipaddress | ||
| requests | ||
| gunicorn No newline at end of file |
Author
There was a problem hiding this comment.
I found it very unstable (server freeze after some time of working) without using a proper wsgi server like gunicorn.
Owner
|
@cypreess thank you very much for the pull request. I see there are many more changes than passing the branch as argument. I've commented those, any discussion from your part is very welcome. Regards. |
Author
|
@carlos-jenkins hey, so lot's of changes you commented were made after my initial PR, and I forgot that PR is from master ( i did not branch back then). But still I think lots of changes I made can be in general valuable I will discuss them in comments. |
carlos-jenkins
added a commit
that referenced
this pull request
Jun 26, 2017
- You receive action "delete" with branch name. - You receive "push" with state "deleted". This triggers hooks for handling push and deletion - and what is even worse - they can be called in random order. This is simpler and give some abstraction over hook scripts that they will be run only once on particular action that happen. Note: Adapted from pull request #8 by cypreess.
carlos-jenkins
added a commit
that referenced
this pull request
Jun 26, 2017
…erfectly fine and used by gitflow approach. The original split is doing: ref/master/feature/this_and_that -> causing that "feature" is selected as branch name, rather than "feature/this_and_that" Note: Adapted from pull request #8 by cypreess.
carlos-jenkins
added a commit
that referenced
this pull request
Jun 26, 2017
- You receive action "delete" with branch name. - You receive "push" with state "deleted". This triggers hooks for handling push and deletion - and what is even worse - they can be called in random order. This is simpler and give some abstraction over hook scripts that they will be run only once on particular action that happen. Note: Adapted from pull request #8 by cypreess.
Sancus
pushed a commit
to thunderbird/python-github-webhooks
that referenced
this pull request
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is extremely helpful for me