Fix Error message outputs ANSI escape sequences (#2556)

NobodyXu · web-flow · commit 69896325faf8 · 2026-05-02T16:42:21.000Z
Fixed #2554 --------- Signed-off-by: Jiahao XU <30436523+NobodyXu@users.noreply.github.com>
diff --git a/crates/bin/src/bin_util.rs b/crates/bin/src/bin_util.rs
@@ -3,11 +3,10 @@ use std::{
     time::Duration,
 };
 
-use binstalk::errors::BinstallError;
-use binstalk::helpers::tasks::AutoAbortJoinHandle;
+use binstalk::{errors::BinstallError, helpers::tasks::AutoAbortJoinHandle};
 use miette::Result;
 use tokio::runtime::Runtime;
-use tracing::{error, info};
+use tracing::{error, info, warn};
 
 use crate::signal::cancel_on_user_sig_term;
 
@@ -19,20 +18,28 @@ pub enum MainExit {
 
 impl Termination for MainExit {
     fn report(self) -> ExitCode {
-        match self {
+        let (code, err) = match self {
             Self::Success(spent) => {
                 if let Some(spent) = spent {
                     info!("Done in {spent:?}");
                 }
-                ExitCode::SUCCESS
+                return ExitCode::SUCCESS;
             }
-            Self::Error(err) => err.report(),
-            Self::Report(err) => {
-                error!("Fatal error:");
-                println!("{err:?}");
-                ExitCode::from(16)
+            Self::Error(err) => {
+                let code = err.exit_code();
+                let Some(report) = err.get_report() else {
+                    warn!("Installation cancelled");
+                    return code;
+                };
+                (code, report)
             }
-        }
+            Self::Report(err) => (ExitCode::from(16), err),
+        };
+
+        error!("Fatal error:");
+        println!("{err:?}");
+
+        code
     }
 }
 
diff --git a/crates/binstalk/src/errors.rs b/crates/binstalk/src/errors.rs
@@ -12,7 +12,6 @@ use itertools::Itertools;
 use miette::{Diagnostic, Report};
 use thiserror::Error;
 use tokio::task;
-use tracing::{error, warn};
 
 use crate::{
     bins,
@@ -525,18 +524,19 @@ impl BinstallError {
             Some(Self::Errors(CrateErrors(errors.into_boxed_slice())))
         }
     }
-}
 
-impl Termination for BinstallError {
-    fn report(self) -> ExitCode {
-        let code = self.exit_code();
+    pub fn get_report(self) -> Option<Report> {
         if let BinstallError::UserAbort = self {
-            warn!("Installation cancelled");
+            None
         } else {
-            error!("Fatal error:\n{:?}", Report::new(self));
+            Some(Report::new(self))
         }
+    }
+}
 
-        code
+impl Termination for BinstallError {
+    fn report(self) -> ExitCode {
+        self.exit_code()
     }
 }
 
