Improve the detection of global/root object#804
Merged
aearly merged 1 commit intocaolan:masterfrom Jun 24, 2015
Merged
Conversation
Collaborator
|
Should we explicitly check for |
Collaborator
Author
|
Self covers that case
|
Collaborator
|
OK, cool. 👍 |
aearly
added a commit
that referenced
this pull request
Jun 24, 2015
Improve the detection of global/root object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to jashkenas/underscore#2152. We were using a similar approach to
asyncs current one in underscore until jashkenas/underscore#2153.The two main benefits of this change are:
strictmode and some tooling (see Use Function("return this") to get global? jashkenas/underscore#2152)WebWorkersupport, you can't usewindowin aWebWorkerbut you can useselfAside: here's the detection method from lodash