Just in case, this is Require.js.

failed. you should use typeof window === 'object &&' instead of window &&?

Oh thanks! Is there some way to edit the merge request? Or should I start a new one?

@trusktr you'd better start a new one ;)

Fwiw, you just have to fix this in a new commit, then push it in the same branch. The pull request will be updated automatically.

If you really want to be clean, you can run git rebase -i before pushing, and git will ask you what to do with your commits - you will be able to merge them into one. After that, a git push -f to update the branch with the newly crafted commit, and you'll be done (the PR will be updated too).

Oh cool ! Agreed

@trusktr what's happening with this?

@fritx @caolan Updated, finally.

@trusktr Note that referencing an undeclared variable directly gives a ReferenceError, that's why the tests are failing. You'll want typeof window !== 'undefined' to check declaration without a ReferenceError. :)

There we go.

bump :)