Callback can be called twice in asyncify when using promises.#1197
Merged
megawac merged 2 commits intocaolan:masterfrom Jun 23, 2016
Merged
Callback can be called twice in asyncify when using promises.#1197megawac merged 2 commits intocaolan:masterfrom
megawac merged 2 commits intocaolan:masterfrom
Conversation
Collaborator
|
Good catch, 100% agree this is the correct behaviour |
| // normal cases, but not here, since we expect unhandled rejections: | ||
| process.on('unhandledRejection', function () { | ||
| // Ignore. | ||
| }); |
Collaborator
There was a problem hiding this comment.
Just realized, can you remove this after the test completes? process.off or only bind it with process.once
Please make a followup pr
suguru03
added a commit
to suguru03/neo-async
that referenced
this pull request
Jun 24, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code to reproduce the bug:
This code will print out:
This is because
.thenon a promise will catch errors, and return a rejected promise, which would then be caught by the.catchcode, calling the callback twice. This PR fixes that behavior by handling both the resolve case and the rejection case in the.thenhandler.