Allow custom retry interval#1161
Merged
megawac merged 4 commits intocaolan:masterfrom May 21, 2016
aianus:custom_retry_interval
Merged
Allow custom retry interval#1161megawac merged 4 commits intocaolan:masterfrom aianus:custom_retry_interval
megawac merged 4 commits intocaolan:masterfrom
aianus:custom_retry_interval
Conversation
Contributor
Author
|
Needed exponential backoff for a project and figured I'd kick my implementation upstream in case anyone finds it useful. |
| }; | ||
| } | ||
|
|
||
| function constantIntervalFunc(interval) { |
Collaborator
There was a problem hiding this comment.
can you import constant from 'lodash/constant' instead
Collaborator
|
This feature also needs to be mentioned in the docs -- also perhaps with an example on how to do exponential back-off, or use a pre-baked array of intervals. |
| acc.times = +t.times || DEFAULT_TIMES; | ||
| acc.interval = +t.interval || DEFAULT_INTERVAL; | ||
|
|
||
| acc.intervalFunc = (typeof t.interval === 'function' ? |
Collaborator
There was a problem hiding this comment.
extraneous bracket.
acc.intervalFunc = typeof t.interval === 'function' ?
t.interval :
constant(+t.interval || DEFAULT_INTERVAL);Otherwise looks good to me and +1
Collaborator
|
Thanks! |
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow interval to be specified as a function(retryCount) : int so users can have exponential backoffs, etc.
#1001