fix(ui): prevent event type slug from overflowing its container#28792
Draft
jaydeep-pipaliya wants to merge 1 commit intocalcom:mainfrom
Draft
fix(ui): prevent event type slug from overflowing its container#28792jaydeep-pipaliya wants to merge 1 commit intocalcom:mainfrom
jaydeep-pipaliya wants to merge 1 commit intocalcom:mainfrom
Conversation
Long event type slugs on the app installation page overflowed their container and broke the layout. Changed the slug <small> element from inline to inline-block and added max-width with text-ellipsis so long URLs truncate cleanly instead of overflowing. Fixes calcom#28533
Member
sahitya-chandra
left a comment
There was a problem hiding this comment.
Can you add a before/after video of the changes
Contributor
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #28533
Long event type slugs on the app installation page (e.g.
/apps/installation/event-types?slug=discord) overflowed their container and broke the layout on smaller screens.Root cause
The slug is rendered in a
<small>element withsm:inlinedisplay. Inline elements ignoreoverflow: hidden, so long slugs had no truncation.Fix
Changed
sm:inline→sm:inline-blockand addedmax-w-xs overflow-hidden text-ellipsisso long slugs truncate with an ellipsis instead of overflowing.Changes
apps/web/components/apps/installation/EventTypesStepCard.tsx— 1 line change