Conversation
Contributor
Author
|
My plan for this PR to wait till 7.0 is released, then do a fresh check with that version and finally get it merged in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Psalm v7 has evolved quite a lot and a stable public release seems to be around the corner
So this is the bare minimum to get level 7 working with a few custom ignores via baseline + a lot of generally ignored errors in the
psalm.xmlEspecially the taint stuff seems to be new/interesting.
We previously dropped Psalm v6 as it deviated from PHPStan more and more, caused more weird issues and was just a pain to maintain. But I think we can give Psalm v7 another try and maybe even get a few goodies out of it (like the taint and mutability-system)