refactor: make attribute classes readonly

josbeir · josbeir · commit a839d543d6bd · 2026-03-14T09:14:09.000+01:00
diff --git a/src/AttributeResolver/Parser.php b/src/AttributeResolver/Parser.php
@@ -310,7 +310,7 @@ protected function parseClass(
     /**
      * Detect declaring class kind from reflection.
      *
-     * @param \ReflectionClass $reflection Class reflection
+     * @param \ReflectionClass<object> $reflection Class reflection
      * @return \Cake\AttributeResolver\Enum\DeclaringClassType
      */
     protected function getDeclaringClassType(ReflectionClass $reflection): DeclaringClassType
diff --git a/src/Routing/Attribute/Delete.php b/src/Routing/Attribute/Delete.php
@@ -22,7 +22,7 @@
  * Declares a DELETE-only route for a controller action.
  */
 #[Attribute(Attribute::TARGET_METHOD | Attribute::IS_REPEATABLE)]
-class Delete extends Route
+readonly class Delete extends Route
 {
     /**
      * Initializes a DELETE route attribute definition.
diff --git a/src/Routing/Attribute/Extensions.php b/src/Routing/Attribute/Extensions.php
@@ -22,7 +22,7 @@
  * Declares supported file extensions for generated routes.
  */
 #[Attribute(Attribute::TARGET_CLASS | Attribute::TARGET_METHOD)]
-class Extensions
+readonly class Extensions
 {
     /**
      * Initializes an extensions attribute definition.
diff --git a/src/Routing/Attribute/Get.php b/src/Routing/Attribute/Get.php
@@ -22,7 +22,7 @@
  * Declares a GET-only route for a controller action.
  */
 #[Attribute(Attribute::TARGET_METHOD | Attribute::IS_REPEATABLE)]
-class Get extends Route
+readonly class Get extends Route
 {
     /**
      * Initializes a GET route attribute definition.
diff --git a/src/Routing/Attribute/Head.php b/src/Routing/Attribute/Head.php
@@ -22,7 +22,7 @@
  * Declares a HEAD-only route for a controller action.
  */
 #[Attribute(Attribute::TARGET_METHOD | Attribute::IS_REPEATABLE)]
-class Head extends Route
+readonly class Head extends Route
 {
     /**
      * Initializes a HEAD route attribute definition.
diff --git a/src/Routing/Attribute/Middleware.php b/src/Routing/Attribute/Middleware.php
@@ -22,7 +22,7 @@
  * Declares middleware names that should be applied to matching routes.
  */
 #[Attribute(Attribute::TARGET_CLASS | Attribute::TARGET_METHOD | Attribute::IS_REPEATABLE)]
-class Middleware
+readonly class Middleware
 {
     /**
      * @var array<string>
diff --git a/src/Routing/Attribute/Options.php b/src/Routing/Attribute/Options.php
@@ -22,7 +22,7 @@
  * Declares an OPTIONS-only route for a controller action.
  */
 #[Attribute(Attribute::TARGET_METHOD | Attribute::IS_REPEATABLE)]
-class Options extends Route
+readonly class Options extends Route
 {
     /**
      * Initializes an OPTIONS route attribute definition.
diff --git a/src/Routing/Attribute/Patch.php b/src/Routing/Attribute/Patch.php
@@ -22,7 +22,7 @@
  * Declares a PATCH-only route for a controller action.
  */
 #[Attribute(Attribute::TARGET_METHOD | Attribute::IS_REPEATABLE)]
-class Patch extends Route
+readonly class Patch extends Route
 {
     /**
      * Initializes a PATCH route attribute definition.
diff --git a/src/Routing/Attribute/Post.php b/src/Routing/Attribute/Post.php
@@ -22,7 +22,7 @@
  * Declares a POST-only route for a controller action.
  */
 #[Attribute(Attribute::TARGET_METHOD | Attribute::IS_REPEATABLE)]
-class Post extends Route
+readonly class Post extends Route
 {
     /**
      * Initializes a POST route attribute definition.
diff --git a/src/Routing/Attribute/Prefix.php b/src/Routing/Attribute/Prefix.php
@@ -22,7 +22,7 @@
  * Declares a routing prefix and optional path override for a controller.
  */
 #[Attribute(Attribute::TARGET_CLASS)]
-class Prefix
+readonly class Prefix
 {
     /**
      * Initializes a controller prefix attribute definition.
diff --git a/src/Routing/Attribute/Put.php b/src/Routing/Attribute/Put.php
@@ -22,7 +22,7 @@
  * Declares a PUT-only route for a controller action.
  */
 #[Attribute(Attribute::TARGET_METHOD | Attribute::IS_REPEATABLE)]
-class Put extends Route
+readonly class Put extends Route
 {
     /**
      * Initializes a PUT route attribute definition.
diff --git a/src/Routing/Attribute/Resource.php b/src/Routing/Attribute/Resource.php
@@ -22,7 +22,7 @@
  * Declares REST resource routes for a controller.
  */
 #[Attribute(Attribute::TARGET_CLASS)]
-class Resource
+readonly class Resource
 {
     /**
      * Initializes a resource attribute definition.
diff --git a/src/Routing/Attribute/Route.php b/src/Routing/Attribute/Route.php
@@ -22,7 +22,7 @@
  * Declares a route for a controller action using PHP attributes.
  */
 #[Attribute(Attribute::TARGET_METHOD | Attribute::IS_REPEATABLE)]
-class Route
+readonly class Route
 {
     /**
      * Initializes a route attribute definition.
diff --git a/src/Routing/Attribute/RouteClass.php b/src/Routing/Attribute/RouteClass.php
@@ -22,7 +22,7 @@
  * Declares the default route class used by attribute routes on a controller.
  */
 #[Attribute(Attribute::TARGET_CLASS)]
-class RouteClass
+readonly class RouteClass
 {
     /**
      * Initializes a default route class attribute definition.
diff --git a/src/Routing/Attribute/Scope.php b/src/Routing/Attribute/Scope.php
@@ -22,7 +22,7 @@
  * Declares shared path, name, and option defaults for controller routes.
  */
 #[Attribute(Attribute::TARGET_CLASS | Attribute::IS_REPEATABLE)]
-class Scope
+readonly class Scope
 {
     /**
      * Initializes a scope attribute definition.

Original file line number	Diff line number	Diff line change
`@@ -310,7 +310,7 @@ protected function parseClass(`
`310`	`310`	`/**`
`311`	`311`	`* Detect declaring class kind from reflection.`
`312`	`312`	`*`
`313`		`- * @param \ReflectionClass $reflection Class reflection`
	`313`	`+ * @param \ReflectionClass<object> $reflection Class reflection`
`314`	`314`	`* @return \Cake\AttributeResolver\Enum\DeclaringClassType`
`315`	`315`	`*/`
`316`	`316`	`protected function getDeclaringClassType(ReflectionClass $reflection): DeclaringClassType`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`* Declares a DELETE-only route for a controller action.`
`23`	`23`	`*/`
`24`	`24`	`#[Attribute(Attribute::TARGET_METHOD \| Attribute::IS_REPEATABLE)]`
`25`		`-class Delete extends Route`
	`25`	`+readonly class Delete extends Route`
`26`	`26`	`{`
`27`	`27`	`/**`
`28`	`28`	`* Initializes a DELETE route attribute definition.`