Skip to content

Commit cf038f6

Browse files
committed
Merge pull request exercism#274 from behrtam/binary-add-test-invalid-input
binary: Expand invalid input tests
2 parents a9bc2b5 + 0bd10c5 commit cf038f6

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

exercises/binary/binary_test.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111

1212
class BinaryTests(unittest.TestCase):
13+
1314
def test_binary_1_is_decimal_1(self):
1415
self.assertEqual(1, parse_binary("1"))
1516

@@ -31,11 +32,17 @@ def test_binary_11010_is_decimal_26(self):
3132
def test_binary_10001101000_is_decimal_1128(self):
3233
self.assertEqual(1128, parse_binary("10001101000"))
3334

34-
def test_invalid_binary_raises_error(self):
35+
def test_invalid_binary_text_only(self):
3536
self.assertRaises(ValueError, parse_binary, "carrot")
3637

37-
def test_invalid_binary_raises_error_2(self):
38+
def test_invalid_binary_number_not_base2(self):
3839
self.assertRaises(ValueError, parse_binary, "102011")
3940

41+
def test_invalid_binary_numbers_with_text(self):
42+
self.assertRaises(ValueError, parse_binary, "10nope")
43+
44+
def test_invalid_binary_text_with_numbers(self):
45+
self.assertRaises(ValueError, parse_binary, "nope10")
46+
4047
if __name__ == '__main__':
4148
unittest.main()

0 commit comments

Comments
 (0)