Fixed various CDS warnings (SAP-samples#242)

beckermarc · web-flow · commit 472bf5954c1b · 2023-08-04T10:17:17.000+02:00
diff --git a/app/common.cds b/app/common.cds
@@ -2,6 +2,7 @@
   Common Annotations shared by all apps
 */
 using {my.bookshop as my} from '../db/index';
+using {sap.common as common} from '@sap/cds/common';
 
 
 ////////////////////////////////////////////////////////////////////////////
@@ -158,8 +159,6 @@ annotate my.Reviews with {
         Text : book.title,
         TextArrangement : #TextOnly
     };
-    date
-    @title : '{i18n>Date}';
     rating
     @title : '{i18n>Rating}';
     text
@@ -382,26 +381,10 @@ annotate common.Currencies with
         {Value : descr}
     ]},
     FieldGroup #Extended : {Data : [
-        {Value : numcode},
-        {Value : minor},
-        {Value : exponent}
+        {Value : minorUnit}
     ]},
 });
 
-
-////////////////////////////////////////////////////////////////////////////
-//
-//	Currencies Elements
-//
-annotate common.Currencies with {
-    numcode
-    @title : '{i18n>NumCode}';
-    minor
-    @title : '{i18n>MinorUnit}';
-    exponent
-    @title : '{i18n>Exponent}';
-}
-
 ////////////////////////////////////////////////////////////////////////////
 //
 //	Fiori requires generated IDs to be annotated with @Core.Computed
diff --git a/db/reviews.cds b/db/reviews.cds
@@ -17,7 +17,6 @@ entity Reviews : cuid, managed {
 
 // input validation
 annotate Reviews with {
-    subject @mandatory;
     title @mandatory;
     rating @assert.range;
     book @mandatory @assert.target;
diff --git a/srv/admin-service.cds b/srv/admin-service.cds
@@ -3,7 +3,7 @@ using {my.bookshop as my} from '../db/index';
 
 @path : 'admin'
 service AdminService @(requires : 'admin') {
-  entity Books   as projection on my.Books actions {
+  entity Books   as projection on my.Books excluding { reviews } actions {
     action addToOrder(order_ID : UUID, quantity : Integer) returns Orders;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ using {my.bookshop as my} from '../db/index';`
`3`	`3`
`4`	`4`	`@path : 'admin'`
`5`	`5`	`service AdminService @(requires : 'admin') {`
`6`		`- entity Books as projection on my.Books actions {`
	`6`	`+ entity Books as projection on my.Books excluding { reviews } actions {`
`7`	`7`	`action addToOrder(order_ID : UUID, quantity : Integer) returns Orders;`
`8`	`8`	`}`
`9`	`9`