MathLib: Added missing testcase for incdec.

orbitcowboy · orbitcowboy · commit 8fe163285fcb · 2014-06-04T08:41:30.000+02:00
diff --git a/lib/mathlib.cpp b/lib/mathlib.cpp
@@ -548,7 +548,6 @@ std::string MathLib::incdec(const std::string & var, const std::string & op)
 
     throw InternalError(0, std::string("Unexpected operation '") + op + "' in MathLib::incdec(). Please report this to Cppcheck developers.");
     return "";
-
 }
 
 std::string MathLib::divide(const std::string &first, const std::string &second)
diff --git a/test/testmathlib.cpp b/test/testmathlib.cpp
@@ -800,6 +800,8 @@ class TestMathLib : public TestFixture {
             const MathLib::biguint decrementedNum = MathLib::toULongNumber(strNum);
             ASSERT_EQUALS(num - 1U, decrementedNum);
         }
+        // invalid operation
+        ASSERT_THROW(MathLib::incdec("1", "x"), InternalError); // throw
     }
 };
 

Original file line number	Diff line number	Diff line change
`@@ -548,7 +548,6 @@ std::string MathLib::incdec(const std::string & var, const std::string & op)`
`548`	`548`
`549`	`549`	`throw InternalError(0, std::string("Unexpected operation '") + op + "' in MathLib::incdec(). Please report this to Cppcheck developers.");`
`550`	`550`	`return "";`
`551`		`-`
`552`	`551`	`}`
`553`	`552`
`554`	`553`	`std::string MathLib::divide(const std::string &first, const std::string &second)`
Original file line number	Diff line number	Diff line change
`@@ -800,6 +800,8 @@ class TestMathLib : public TestFixture {`
`800`	`800`	`const MathLib::biguint decrementedNum = MathLib::toULongNumber(strNum);`
`801`	`801`	`ASSERT_EQUALS(num - 1U, decrementedNum);`
`802`	`802`	`}`
	`803`	`+ // invalid operation`
	`804`	`+ ASSERT_THROW(MathLib::incdec("1", "x"), InternalError); // throw`
`803`	`805`	`}`
`804`	`806`	`};`
`805`	`807`