checkpatch: make the memory barrier test noisier

JoePerches · torvalds · commit c1fd7bb99637 · 2013-11-13T12:09:25.000+09:00
Peter Zijlstra prefers that comments be required near uses of memory
barriers.

Change the message level for memory barrier uses from a --strict test only
to a normal WARN so it's always emitted.

This might produce false positives around insertions of memory barriers
when a comment is outside the patch context block.

And checkpatch is still stupid, it only looks for existence of any
comment, not at the comment content.

Signed-off-by: Joe Perches &lt;joe@perches.com&gt;
Suggested-by: Peter Zijlstra &lt;peterz@infradead.org&gt;
Acked-by: Peter Zijlstra &lt;peterz@infradead.org&gt;
Acked-by: Paul E. McKenney &lt;paulmck@linux.vnet.ibm.com&gt;
Cc: Oliver Neukum &lt;oliver@neukum.org&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
@@ -3850,8 +3850,8 @@ sub process {
 # check for memory barriers without a comment.
 		if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
 			if (!ctx_has_comment($first_line, $linenr)) {
-				CHK("MEMORY_BARRIER",
-				    "memory barrier without comment\n" . $herecurr);
+				WARN("MEMORY_BARRIER",
+				     "memory barrier without comment\n" . $herecurr);
 			}
 		}
 # check of hardware specific defines

Original file line number	Diff line number	Diff line change
`@@ -3850,8 +3850,8 @@ sub process {`
`3850`	`3850`	`# check for memory barriers without a comment.`
`3851`	`3851`	`if ($line =~ /\b(mb\|rmb\|wmb\|read_barrier_depends\|smp_mb\|smp_rmb\|smp_wmb\|smp_read_barrier_depends)\(/) {`
`3852`	`3852`	`if (!ctx_has_comment($first_line, $linenr)) {`
`3853`		`- CHK("MEMORY_BARRIER",`
`3854`		`- "memory barrier without comment\n" . $herecurr);`
	`3853`	`+ WARN("MEMORY_BARRIER",`
	`3854`	`+ "memory barrier without comment\n" . $herecurr);`
`3855`	`3855`	`}`
`3856`	`3856`	`}`
`3857`	`3857`	`# check of hardware specific defines`