Skip to content

Commit 1c32fd0

Browse files
idryomovtorvalds
authored andcommitted
kernel-doc: drop the -filelist option, it doesn't work
I also found the -filelist option, but apparently the implementation is broken, and it was broken from the very first git commit. For the -filelist option I suggest the removal (I wasn't able to find any users of it, moreover it's not even listed in the usage() output, so presumably nobody knows about it). Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent a9e7314 commit 1c32fd0

1 file changed

Lines changed: 1 addition & 13 deletions

File tree

scripts/kernel-doc

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ use strict;
1313
## This software falls under the GNU General Public License. ##
1414
## Please read the COPYING file for more information ##
1515

16-
# w.o. 03-11-2000: added the '-filelist' option.
17-
1816
# 18/01/2001 - Cleanups
1917
# Functions prototyped as foo(void) same as foo()
2018
# Stop eval'ing where we don't need to.
@@ -245,7 +243,7 @@ my $man_date = ('January', 'February', 'March', 'April', 'May', 'June',
245243
# could cause "use of undefined value" or other bugs.
246244
my ($function, %function_table, %parametertypes, $declaration_purpose);
247245
my ($type, $declaration_name, $return_type);
248-
my ($newsection, $newcontents, $prototype, $filelist, $brcount, %source_map);
246+
my ($newsection, $newcontents, $prototype, $brcount, %source_map);
249247

250248
if (defined($ENV{'KBUILD_VERBOSE'})) {
251249
$verbose = "$ENV{'KBUILD_VERBOSE'}";
@@ -338,8 +336,6 @@ while ($ARGV[0] =~ m/^-(.*)/) {
338336
$verbose = 1;
339337
} elsif (($cmd eq "-h") || ($cmd eq "--help")) {
340338
usage();
341-
} elsif ($cmd eq '-filelist') {
342-
$filelist = shift @ARGV;
343339
} elsif ($cmd eq '-no-doc-sections') {
344340
$no_doc_sections = 1;
345341
}
@@ -1811,14 +1807,6 @@ if (open(SOURCE_MAP, "<.tmp_filelist.txt")) {
18111807
close(SOURCE_MAP);
18121808
}
18131809

1814-
if ($filelist) {
1815-
open(FLIST,"<$filelist") or die "Can't open file list $filelist";
1816-
while(<FLIST>) {
1817-
chop;
1818-
process_file($_);
1819-
}
1820-
}
1821-
18221810
foreach (@ARGV) {
18231811
chomp;
18241812
process_file($_);

0 commit comments

Comments
 (0)