Skip to content

Commit bced108

Browse files
tswasttswast
authored
Skip update_table and update_dataset tests until etag issue is resolved. (googleapis#5590)
* Skip update_table and update_dataset tests until etag issue is resolved. * Flake8 fixes
1 parent dd330d6 commit bced108

2 files changed

Lines changed: 48 additions & 0 deletions

File tree

‎bigquery/tests/system.py‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,10 @@ def test_get_dataset(self):
174174
self.assertEqual(got.friendly_name, 'Friendly')
175175
self.assertEqual(got.description, 'Description')
176176

177+
@pytest.mark.skip(reason=(
178+
'update_dataset() is flaky '
179+
'https://github.com/GoogleCloudPlatform/google-cloud-python/issues/'
180+
'5588'))
177181
def test_update_dataset(self):
178182
dataset = self.temp_dataset(_make_dataset_id('update_dataset'))
179183
self.assertTrue(_dataset_exists(dataset))
@@ -318,6 +322,10 @@ def test_list_tables(self):
318322
table.dataset_id == DATASET_ID)]
319323
self.assertEqual(len(created), len(tables_to_create))
320324

325+
@pytest.mark.skip(reason=(
326+
'update_table() is flaky '
327+
'https://github.com/GoogleCloudPlatform/google-cloud-python/issues/'
328+
'5589'))
321329
def test_update_table(self):
322330
dataset = self.temp_dataset(_make_dataset_id('update_table'))
323331

@@ -357,6 +365,10 @@ def test_update_table(self):
357365
with self.assertRaises(PreconditionFailed):
358366
Config.CLIENT.update_table(table2, ['description'])
359367

368+
@pytest.mark.skip(reason=(
369+
'update_table() is flaky '
370+
'https://github.com/GoogleCloudPlatform/google-cloud-python/issues/'
371+
'5589'))
360372
def test_update_table_schema(self):
361373
dataset = self.temp_dataset(_make_dataset_id('update_table'))
362374

‎docs/bigquery/snippets.py‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,9 @@ def test_dataset_exists(client, to_delete):
280280
assert not dataset_exists(client, client.dataset('i_dont_exist'))
281281

282282

283+
@pytest.mark.skip(reason=(
284+
'update_dataset() is flaky '
285+
'https://github.com/GoogleCloudPlatform/google-cloud-python/issues/5588'))
283286
def test_update_dataset_description(client, to_delete):
284287
"""Update a dataset's description."""
285288
dataset_id = 'update_dataset_description_{}'.format(_millis())
@@ -303,6 +306,9 @@ def test_update_dataset_description(client, to_delete):
303306
# [END bigquery_update_dataset_description]
304307

305308

309+
@pytest.mark.skip(reason=(
310+
'update_dataset() is flaky '
311+
'https://github.com/GoogleCloudPlatform/google-cloud-python/issues/5588'))
306312
def test_update_dataset_default_table_expiration(client, to_delete):
307313
"""Update a dataset's default table expiration."""
308314
dataset_id = 'update_dataset_default_expiration_{}'.format(_millis())
@@ -327,6 +333,9 @@ def test_update_dataset_default_table_expiration(client, to_delete):
327333
# [END bigquery_update_dataset_expiration]
328334

329335

336+
@pytest.mark.skip(reason=(
337+
'update_dataset() is flaky '
338+
'https://github.com/GoogleCloudPlatform/google-cloud-python/issues/5588'))
330339
def test_manage_dataset_labels(client, to_delete):
331340
dataset_id = 'label_dataset_{}'.format(_millis())
332341
dataset = bigquery.Dataset(client.dataset(dataset_id))
@@ -384,6 +393,9 @@ def test_manage_dataset_labels(client, to_delete):
384393
# [END bigquery_delete_label_dataset]
385394

386395

396+
@pytest.mark.skip(reason=(
397+
'update_dataset() is flaky '
398+
'https://github.com/GoogleCloudPlatform/google-cloud-python/issues/5588'))
387399
def test_update_dataset_access(client, to_delete):
388400
"""Update a dataset's access controls."""
389401
dataset_id = 'update_dataset_access_{}'.format(_millis())
@@ -504,6 +516,9 @@ def test_create_table(client, to_delete):
504516
to_delete.insert(0, table)
505517

506518

519+
@pytest.mark.skip(reason=(
520+
'update_table() is flaky '
521+
'https://github.com/GoogleCloudPlatform/google-cloud-python/issues/5589'))
507522
def test_create_table_then_add_schema(client, to_delete):
508523
"""Create a table without specifying a schema"""
509524
dataset_id = 'create_table_without_schema_dataset_{}'.format(_millis())
@@ -796,6 +811,9 @@ def test_table_exists(client, to_delete):
796811
assert not table_exists(client, dataset.table('i_dont_exist'))
797812

798813

814+
@pytest.mark.skip(reason=(
815+
'update_table() is flaky '
816+
'https://github.com/GoogleCloudPlatform/google-cloud-python/issues/5589'))
799817
def test_manage_table_labels(client, to_delete):
800818
dataset_id = 'label_table_dataset_{}'.format(_millis())
801819
table_id = 'label_table_{}'.format(_millis())
@@ -860,6 +878,9 @@ def test_manage_table_labels(client, to_delete):
860878
# [END bigquery_delete_label_table]
861879

862880

881+
@pytest.mark.skip(reason=(
882+
'update_table() is flaky '
883+
'https://github.com/GoogleCloudPlatform/google-cloud-python/issues/5589'))
863884
def test_update_table_description(client, to_delete):
864885
"""Update a table's description."""
865886
dataset_id = 'update_table_description_dataset_{}'.format(_millis())
@@ -888,6 +909,9 @@ def test_update_table_description(client, to_delete):
888909
# [END bigquery_update_table_description]
889910

890911

912+
@pytest.mark.skip(reason=(
913+
'update_table() is flaky '
914+
'https://github.com/GoogleCloudPlatform/google-cloud-python/issues/5589'))
891915
def test_update_table_expiration(client, to_delete):
892916
"""Update a table's expiration time."""
893917
dataset_id = 'update_table_expiration_dataset_{}'.format(_millis())
@@ -922,6 +946,9 @@ def test_update_table_expiration(client, to_delete):
922946
# [END bigquery_update_table_expiration]
923947

924948

949+
@pytest.mark.skip(reason=(
950+
'update_table() is flaky '
951+
'https://github.com/GoogleCloudPlatform/google-cloud-python/issues/5589'))
925952
def test_add_empty_column(client, to_delete):
926953
"""Adds an empty column to an existing table."""
927954
dataset_id = 'add_empty_column_dataset_{}'.format(_millis())
@@ -954,6 +981,9 @@ def test_add_empty_column(client, to_delete):
954981
# [END bigquery_add_empty_column]
955982

956983

984+
@pytest.mark.skip(reason=(
985+
'update_table() is flaky '
986+
'https://github.com/GoogleCloudPlatform/google-cloud-python/issues/5589'))
957987
def test_relax_column(client, to_delete):
958988
"""Updates a schema field from required to nullable."""
959989
dataset_id = 'relax_column_dataset_{}'.format(_millis())
@@ -992,6 +1022,9 @@ def test_relax_column(client, to_delete):
9921022
to_delete.insert(0, table)
9931023

9941024

1025+
@pytest.mark.skip(reason=(
1026+
'update_table() is flaky '
1027+
'https://github.com/GoogleCloudPlatform/google-cloud-python/issues/5589'))
9951028
def test_update_table_cmek(client, to_delete):
9961029
"""Patch a table's metadata."""
9971030
dataset_id = 'update_table_cmek_{}'.format(_millis())
@@ -1072,6 +1105,9 @@ def test_browse_table_data(client, to_delete, capsys):
10721105
assert len(out) == 11
10731106

10741107

1108+
@pytest.mark.skip(reason=(
1109+
'update_table() is flaky '
1110+
'https://github.com/GoogleCloudPlatform/google-cloud-python/issues/5589'))
10751111
def test_manage_views(client, to_delete):
10761112
project = client.project
10771113
source_dataset_id = 'source_dataset_{}'.format(_millis())

0 commit comments

Comments
 (0)