Log that special files were skipped.

bruce-one · bruce-one · commit 6a4a6a0bd129 · 2017-06-22T11:33:11.000+10:00
This is flushed at the end of the copy command, or on exit if that
doesn't happen first.
diff --git a/src/common.js b/src/common.js
@@ -84,6 +84,28 @@ function log() {
 }
 exports.log = log;
 
+var _logLater = [];
+// facilate logging informational messages at the end of a command
+function logLater(message) {
+  if (!_logLater.length) {
+    // only logs if outputLaterLog hasn't been called
+    process.on('exit', outputLaterLog);
+  }
+  if (_logLater.indexOf(message) === -1) {
+    _logLater = _logLater.concat(message);
+  }
+}
+exports.logLater = logLater;
+
+function outputLaterLog() {
+  _logLater.forEach(function (m) {
+    log(m);
+  });
+  _logLater = [];
+  process.removeListener('exit', outputLaterLog);
+}
+exports.outputLaterLog = outputLaterLog;
+
 // Converts strings to be equivalent across all platforms. Primarily responsible
 // for making sure we use '/' instead of '\' as path separators, but this may be
 // expanded in the future if necessary
diff --git a/src/cp.js b/src/cp.js
@@ -58,6 +58,7 @@ function copyFileSync(srcFile, destFile, options) {
     if (srcFileStat.isCharacterDevice()) type = 'block device';
     if (srcFileStat.isBlockDevice()) type = 'character device';
     common.error('copyFileSync: ' + type + ' is not supported (' + srcFile + ')', { continue: true });
+    common.logLater('copyFileSync: Special files were encountered during this operation. Please investigate shelljs plugins if you would like to add support for these.');
   } else {
     var buf = common.buffer();
     var bufLength = buf.length;
@@ -308,6 +309,7 @@ function _cp(options, sources, dest) {
     }
   }); // forEach(src)
 
+  common.outputLaterLog();
   return new common.ShellString('', common.state.error, common.state.errorCode);
 }
 module.exports = _cp;

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,7 @@ function copyFileSync(srcFile, destFile, options) {`
`58`	`58`	`if (srcFileStat.isCharacterDevice()) type = 'block device';`
`59`	`59`	`if (srcFileStat.isBlockDevice()) type = 'character device';`
`60`	`60`	`common.error('copyFileSync: ' + type + ' is not supported (' + srcFile + ')', { continue: true });`
	`61`	`+ common.logLater('copyFileSync: Special files were encountered during this operation. Please investigate shelljs plugins if you would like to add support for these.');`
`61`	`62`	`} else {`
`62`	`63`	`var buf = common.buffer();`
`63`	`64`	`var bufLength = buf.length;`
`@@ -308,6 +309,7 @@ function _cp(options, sources, dest) {`
`308`	`309`	`}`
`309`	`310`	`}); // forEach(src)`
`310`	`311`
	`312`	`+ common.outputLaterLog();`
`311`	`313`	`return new common.ShellString('', common.state.error, common.state.errorCode);`
`312`	`314`	`}`
`313`	`315`	`module.exports = _cp;`