From 1732d8392576b04a11cbabe92e84eb4837026773 Mon Sep 17 00:00:00 2001 From: Shivam Kumar Date: Tue, 7 Apr 2026 18:30:19 +0530 Subject: [PATCH 1/2] fix github actions workflow --- .github/workflows/reviewing_changes.yml | 17 +++++++++++++---- .../SpecFlow_BrowserStack.csproj | 2 +- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/.github/workflows/reviewing_changes.yml b/.github/workflows/reviewing_changes.yml index 319189c..264ad55 100644 --- a/.github/workflows/reviewing_changes.yml +++ b/.github/workflows/reviewing_changes.yml @@ -17,7 +17,16 @@ jobs: fail-fast: false max-parallel: 3 matrix: - dotnet: ['6.0.x', '5.0.x'] + dotnet: ['6.0.x', '8.0.x', '9.0.x', '10.0.x'] + include: + - dotnet: '6.0.x' + target-framework: 'net6.0' + - dotnet: '8.0.x' + target-framework: 'net8.0' + - dotnet: '9.0.x' + target-framework: 'net9.0' + - dotnet: '10.0.x' + target-framework: 'net10.0' os: [ windows-latest ] name: SpecFlow Repo ${{ matrix.dotnet }} - ${{ matrix.os }} Sample env: @@ -53,13 +62,13 @@ jobs: dotnet-version: ${{ matrix.dotnet }} - name: Install dependencies - run: dotnet build + run: dotnet build /p:TargetFramework=${{ matrix.target-framework }} - name: Run sample tests - run: dotnet test --filter "Category=sample-test" + run: dotnet test --filter "Category=sample-test" /p:TargetFramework=${{ matrix.target-framework }} - name: Run local tests - run: dotnet test --filter "Category=sample-local-test" + run: dotnet test --filter "Category=sample-local-test" /p:TargetFramework=${{ matrix.target-framework }} - if: always() uses: actions/github-script@98814c53be79b1d30f795b907e553d8679345975 diff --git a/SpecFlow_BrowserStack/SpecFlow_BrowserStack.csproj b/SpecFlow_BrowserStack/SpecFlow_BrowserStack.csproj index 7326f42..39cf27b 100644 --- a/SpecFlow_BrowserStack/SpecFlow_BrowserStack.csproj +++ b/SpecFlow_BrowserStack/SpecFlow_BrowserStack.csproj @@ -1,7 +1,7 @@  - net6.0 + net6.0;net8.0;net9.0;net10.0 false enable enable From 97728939b3a6ba22f095bf5184876e382a3ddc20 Mon Sep 17 00:00:00 2001 From: Shivam Kumar Date: Wed, 8 Apr 2026 20:35:16 +0530 Subject: [PATCH 2/2] added global.json for version match --- .github/workflows/reviewing_changes.yml | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/.github/workflows/reviewing_changes.yml b/.github/workflows/reviewing_changes.yml index 264ad55..2c39d01 100644 --- a/.github/workflows/reviewing_changes.yml +++ b/.github/workflows/reviewing_changes.yml @@ -58,17 +58,26 @@ jobs: } - name: Setup dotnet uses: actions/setup-dotnet@v3 + id: setup-dotnet with: dotnet-version: ${{ matrix.dotnet }} + - name: Pin SDK version via global.json + run: | + $major = "${{ matrix.target-framework }}".Replace("net","").Split(".")[0] + $version = "$major.0.100" + "{`"sdk`":{`"version`":`"$version`",`"rollForward`":`"latestFeature`"}}" | Set-Content global.json + Get-Content global.json + shell: pwsh + - name: Install dependencies - run: dotnet build /p:TargetFramework=${{ matrix.target-framework }} + run: dotnet build /p:TargetFrameworks=${{ matrix.target-framework }} /p:TargetFramework=${{ matrix.target-framework }} - name: Run sample tests - run: dotnet test --filter "Category=sample-test" /p:TargetFramework=${{ matrix.target-framework }} + run: dotnet test --filter "Category=sample-test" /p:TargetFrameworks=${{ matrix.target-framework }} /p:TargetFramework=${{ matrix.target-framework }} - name: Run local tests - run: dotnet test --filter "Category=sample-local-test" /p:TargetFramework=${{ matrix.target-framework }} + run: dotnet test --filter "Category=sample-local-test" /p:TargetFrameworks=${{ matrix.target-framework }} /p:TargetFramework=${{ matrix.target-framework }} - if: always() uses: actions/github-script@98814c53be79b1d30f795b907e553d8679345975