From c6700e7ced28dd9770f60c7b47f97f7655c3c13c Mon Sep 17 00:00:00 2001 From: Shivam Kumar Date: Tue, 7 Apr 2026 17:52:07 +0530 Subject: [PATCH 1/4] fix github actions workflow --- .github/workflows/reviewing_changes.yml | 22 ++++++++++++++------ NUnit-BrowserStack/NUnit-BrowserStack.csproj | 2 +- 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/.github/workflows/reviewing_changes.yml b/.github/workflows/reviewing_changes.yml index dfd638e..b13b302 100644 --- a/.github/workflows/reviewing_changes.yml +++ b/.github/workflows/reviewing_changes.yml @@ -16,8 +16,19 @@ jobs: strategy: fail-fast: false max-parallel: 3 + # .net5 runner doesn't installed at runtime, so skipping it and adding other .net latest versions. + # added target-framework in matrix to avoid runtime errors as each runner has only its matching runtime installed. matrix: - dotnet: ['6.0.x', '5.0.x'] + dotnet: ['6.0.x', '8.0.x', '9.0.x', '10.0.x'] + include: + - dotnet: '6.0.x' + target-framework: 'net6.0' + - dotnet: '8.0.x' + target-framework: 'net8.0' + - dotnet: '9.0.x' + target-framework: 'net9.0' + - dotnet: '10.0.x' + target-framework: 'net10.0' os: [ windows-latest ] name: NUnit Repo ${{ matrix.dotnet }} - ${{ matrix.os }} Sample env: @@ -53,16 +64,15 @@ jobs: dotnet-version: ${{ matrix.dotnet }} - name: Install dependencies - run: | + run: | dotnet --version - dotnet build - + dotnet build /p:TargetFramework=${{ matrix.target-framework }} - name: Run sample tests - run: dotnet test --filter "Category=sample-test" + run: dotnet test --filter "Category=sample-test" /p:TargetFramework=${{ matrix.target-framework }} - name: Run local tests - run: dotnet test --filter "Category=sample-local-test" + run: dotnet test --filter "Category=sample-local-test" /p:TargetFramework=${{ matrix.target-framework }} - if: always() uses: actions/github-script@98814c53be79b1d30f795b907e553d8679345975 diff --git a/NUnit-BrowserStack/NUnit-BrowserStack.csproj b/NUnit-BrowserStack/NUnit-BrowserStack.csproj index c3e4e8b..3161a59 100644 --- a/NUnit-BrowserStack/NUnit-BrowserStack.csproj +++ b/NUnit-BrowserStack/NUnit-BrowserStack.csproj @@ -1,7 +1,7 @@  - net6.0 + net6.0;net8.0;net9.0;net10.0 SingleTest SingleTest enable From 099a514b389a5203196016fa5f2da982467d03f1 Mon Sep 17 00:00:00 2001 From: Shivam Kumar Date: Wed, 8 Apr 2026 19:39:55 +0530 Subject: [PATCH 2/4] fix: use global.json --- .github/workflows/reviewing_changes.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/reviewing_changes.yml b/.github/workflows/reviewing_changes.yml index b13b302..e0d9cc7 100644 --- a/.github/workflows/reviewing_changes.yml +++ b/.github/workflows/reviewing_changes.yml @@ -59,10 +59,18 @@ jobs: console.log('Failed to create check run') } - name: Setup dotnet + id: setup-dotnet uses: actions/setup-dotnet@v3 with: dotnet-version: ${{ matrix.dotnet }} + - name: Pin SDK version via global.json + run: | + $version = "${{ matrix.target-framework }}".Replace("net","") + ".0" + "{`"sdk`":{`"version`":`"$version`",`"rollForward`":`"latestPatch`"}}" | Set-Content global.json + Get-Content global.json + shell: pwsh + - name: Install dependencies run: | dotnet --version From a03cf4206b5ac481698b5c4775be9f918b780fe5 Mon Sep 17 00:00:00 2001 From: Shivam Kumar Date: Wed, 8 Apr 2026 19:48:23 +0530 Subject: [PATCH 3/4] fix: requierd version for global.json --- .github/workflows/reviewing_changes.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/reviewing_changes.yml b/.github/workflows/reviewing_changes.yml index e0d9cc7..2e24895 100644 --- a/.github/workflows/reviewing_changes.yml +++ b/.github/workflows/reviewing_changes.yml @@ -66,8 +66,9 @@ jobs: - name: Pin SDK version via global.json run: | - $version = "${{ matrix.target-framework }}".Replace("net","") + ".0" - "{`"sdk`":{`"version`":`"$version`",`"rollForward`":`"latestPatch`"}}" | Set-Content global.json + $major = "${{ matrix.target-framework }}".Replace("net","").Split(".")[0] + $version = "$major.0.100" + "{`"sdk`":{`"version`":`"$version`",`"rollForward`":`"latestFeature`"}}" | Set-Content global.json Get-Content global.json shell: pwsh From cff99e96402d3c9e2529f447affc4dc779eba026 Mon Sep 17 00:00:00 2001 From: Shivam Kumar Date: Wed, 8 Apr 2026 20:22:27 +0530 Subject: [PATCH 4/4] added global.json for version match --- .github/workflows/reviewing_changes.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/reviewing_changes.yml b/.github/workflows/reviewing_changes.yml index 2e24895..10e3173 100644 --- a/.github/workflows/reviewing_changes.yml +++ b/.github/workflows/reviewing_changes.yml @@ -75,13 +75,13 @@ jobs: - name: Install dependencies run: | dotnet --version - dotnet build /p:TargetFramework=${{ matrix.target-framework }} + dotnet build /p:TargetFrameworks=${{ matrix.target-framework }} /p:TargetFramework=${{ matrix.target-framework }} - name: Run sample tests - run: dotnet test --filter "Category=sample-test" /p:TargetFramework=${{ matrix.target-framework }} + run: dotnet test --filter "Category=sample-test" /p:TargetFrameworks=${{ matrix.target-framework }} /p:TargetFramework=${{ matrix.target-framework }} - name: Run local tests - run: dotnet test --filter "Category=sample-local-test" /p:TargetFramework=${{ matrix.target-framework }} + run: dotnet test --filter "Category=sample-local-test" /p:TargetFrameworks=${{ matrix.target-framework }} /p:TargetFramework=${{ matrix.target-framework }} - if: always() uses: actions/github-script@98814c53be79b1d30f795b907e553d8679345975