fix github actions workflow

shivamku-BS · shivamku-BS · commit c6700e7ced28 · 2026-04-07T17:52:07.000+05:30
diff --git a/.github/workflows/reviewing_changes.yml b/.github/workflows/reviewing_changes.yml
@@ -16,8 +16,19 @@ jobs:
     strategy:
       fail-fast: false
       max-parallel: 3
+      # .net5 runner doesn't installed at runtime, so skipping it and adding other .net latest versions.
+      # added target-framework in matrix to avoid runtime errors as each runner has only its matching runtime installed.
       matrix:
-        dotnet: ['6.0.x', '5.0.x']
+        dotnet: ['6.0.x', '8.0.x', '9.0.x', '10.0.x']
+        include:
+          - dotnet: '6.0.x'
+            target-framework: 'net6.0'
+          - dotnet: '8.0.x'
+            target-framework: 'net8.0'
+          - dotnet: '9.0.x'
+            target-framework: 'net9.0'
+          - dotnet: '10.0.x'
+            target-framework: 'net10.0'
         os: [ windows-latest ]
     name: NUnit Repo ${{ matrix.dotnet }} - ${{ matrix.os }} Sample
     env:
@@ -53,16 +64,15 @@ jobs:
           dotnet-version: ${{ matrix.dotnet }}
 
       - name: Install dependencies
-        run: | 
+        run: |
           dotnet --version
-          dotnet build
-          
+          dotnet build /p:TargetFramework=${{ matrix.target-framework }}
 
       - name: Run sample tests
-        run: dotnet test --filter "Category=sample-test"
+        run: dotnet test --filter "Category=sample-test" /p:TargetFramework=${{ matrix.target-framework }}
 
       - name: Run local tests
-        run: dotnet test --filter "Category=sample-local-test"
+        run: dotnet test --filter "Category=sample-local-test" /p:TargetFramework=${{ matrix.target-framework }}
 
       - if: always()
         uses: actions/github-script@98814c53be79b1d30f795b907e553d8679345975
diff --git a/NUnit-BrowserStack/NUnit-BrowserStack.csproj b/NUnit-BrowserStack/NUnit-BrowserStack.csproj
@@ -1,7 +1,7 @@
 ﻿<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net6.0</TargetFramework>
+    <TargetFrameworks>net6.0;net8.0;net9.0;net10.0</TargetFrameworks>
     <RootNamespace>SingleTest</RootNamespace>
     <AssemblyName>SingleTest</AssemblyName>
     <ImplicitUsings>enable</ImplicitUsings>
