Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dystudio/node-sql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: brianc/node-sql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Aug 24, 2024

  1. Type change to allow typescript > 2.7.2 (brianc#421) 

    Typescript versions greater than 2.7.2, `keyof` produces `string|number|symbol`, failing on line 40.

One fix is have on lines 19 and 22 `Name extends string|number|symbol` instead of `Name extends string`. But this work around may feel a bit not intuitive.

Change directly on line 40, `&` with `string` does the trick of fitting types.
    @3n-mb
    3n-mb authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    cc15b67 View commit details
    Browse the repository at this point in the history
Loading