Correctly reference inspect parameter kinds

bfrascher · sebastinas · commit 0a5bd6e84e10 · 2019-04-02T22:19:09.000+02:00
Instead of referencing parameter kinds as class attributes on the private
`_ParameterKind` class we reference them on the public `Parameter` class.  This
has two advantages:

1) We don't use a private interface.
2) The class attributes on `_ParameterKind` have only been added in Python 3.5,
   but on `Parameter` they have existed since Python 3.3.
diff --git a/bpython/inspection.py b/bpython/inspection.py
@@ -304,18 +304,18 @@ def get_argspec_from_signature(f):
         if parameter.annotation is not inspect._empty:
             annotations[parameter.name] = parameter.annotation
 
-        if parameter.kind == inspect._ParameterKind.POSITIONAL_OR_KEYWORD:
+        if parameter.kind == inspect.Parameter.POSITIONAL_OR_KEYWORD:
             args.append(parameter.name)
             if parameter.default is not inspect._empty:
                 defaults.append(parameter.default)
-        elif parameter.kind == inspect._ParameterKind.POSITIONAL_ONLY:
+        elif parameter.kind == inspect.Parameter.POSITIONAL_ONLY:
             args.append(parameter.name)
-        elif parameter.kind == inspect._ParameterKind.VAR_POSITIONAL:
+        elif parameter.kind == inspect.Parameter.VAR_POSITIONAL:
             varargs = parameter.name
-        elif parameter.kind == inspect._ParameterKind.KEYWORD_ONLY:
+        elif parameter.kind == inspect.Parameter.KEYWORD_ONLY:
             kwonly.append(parameter.name)
             kwonly_defaults[parameter.name] = parameter.default
-        elif parameter.kind == inspect._ParameterKind.VAR_KEYWORD:
+        elif parameter.kind == inspect.Parameter.VAR_KEYWORD:
             varkwargs = parameter.name
 
     # inspect.getfullargspec returns None for 'defaults', 'kwonly_defaults' and
