feat(vector_indexing_suite): implement remove

e-kwsm · stefanseefeld · commit 660e8944ffcf · 2026-07-05T22:30:33.000-04:00
diff --git a/include/boost/python/suite/indexing/vector_indexing_suite.hpp b/include/boost/python/suite/indexing/vector_indexing_suite.hpp
@@ -65,6 +65,7 @@ namespace boost { namespace python {
                 .def("append", &base_append)
                 .def("count", &base_count)
                 .def("extend", &base_extend)
+                .def("remove", &base_remove)
             ;
         }
         
@@ -265,6 +266,42 @@ namespace boost { namespace python {
             base_extend(container, v);
             return object(container);
         }
+
+        static void
+        base_remove(Container& container, object v)
+        {
+            extract<data_type&> key(v);
+            if (key.check())
+            {
+                auto i = std::find(container.begin(), container.end(), key());
+                if (i == container.end())
+                {
+                    PyErr_SetString(PyExc_ValueError, "remove(x): x not in vector_indexing_suite");
+                    throw_error_already_set();
+                }
+                container.erase(i);
+            }
+            else
+            {
+                extract<data_type> key(v);
+                if (key.check())
+                {
+                    auto i = std::find(container.begin(), container.end(), key());
+                    if (i == container.end())
+                    {
+                        PyErr_SetString(PyExc_ValueError, "remove(x): x not in vector_indexing_suite");
+                        throw_error_already_set();
+                    }
+                    container.erase(i);
+                }
+                else
+                {
+                    PyErr_SetString(PyExc_TypeError,
+                        "Attempting to remove an invalid type");
+                    throw_error_already_set();
+                }
+            }
+        }
     };
        
 }} // namespace boost::python 
diff --git a/test/vector_indexing_suite.py b/test/vector_indexing_suite.py
@@ -78,6 +78,14 @@
 >>> print_xvec(v)
 [ yaba c d e ]
 
+>>> v2 = XVec()
+>>> v2[:] = [X('b'), X('a'), X('c'), X('b'), X('a')]
+>>> try: v2.remove("z")
+... except ValueError: pass
+>>> v2.remove("a")
+>>> print_xvec(v2)
+[ b c b a ]
+
 #####################################################################
 # Calling a mutating function of a container element
 #####################################################################
