Adding a few missing code coverage tests

joaquincasares · joaquincasares · commit 9c92a5066726 · 2014-04-23T20:39:10.000-05:00
diff --git a/tests/unit/test_connection.py b/tests/unit/test_connection.py
@@ -11,6 +11,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+from cassandra.cluster import Cluster
 
 try:
     import unittest2 as unittest
@@ -152,3 +153,18 @@ def test_not_implemented(self):
         self.assertRaises(NotImplementedError, c.close)
         self.assertRaises(NotImplementedError, c.register_watcher, None, None)
         self.assertRaises(NotImplementedError, c.register_watchers, None)
+
+    def test_set_keyspace_blocking(self):
+        c = self.make_connection()
+
+        self.assertEqual(c.keyspace, None)
+        c.set_keyspace_blocking(None)
+        self.assertEqual(c.keyspace, None)
+
+        c.keyspace = 'ks'
+        c.set_keyspace_blocking('ks')
+        self.assertEqual(c.keyspace, 'ks')
+
+    def test_set_connection_class(self):
+        cluster = Cluster(connection_class='test')
+        self.assertEqual('test', cluster.connection_class)
diff --git a/tests/unit/test_marshalling.py b/tests/unit/test_marshalling.py
@@ -11,6 +11,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+from cassandra.marshal import bitlength
 
 try:
     import unittest2 as unittest
@@ -131,3 +132,8 @@ def test_marshalling(self):
             self.assertEqual(type(whatwegot), type(serializedval),
                              msg='Marshaller for %s (%s) gave wrong type (%s instead of %s)'
                                  % (valtype, marshaller, type(whatwegot), type(serializedval)))
+
+    def test_bitlength(self):
+        self.assertEqual(bitlength(9), 4)
+        self.assertEqual(bitlength(-10), 0)
+        self.assertEqual(bitlength(0), 0)
diff --git a/tests/unit/test_metadata.py b/tests/unit/test_metadata.py
@@ -147,6 +147,9 @@ def test_simple_strategy_make_token_replica_map(self):
         self.assertItemsEqual(rf3_replicas[MD5Token(200)], [host3, host1, host2])
 
 
+    def test_ss_equals(self):
+        self.assertNotEqual(SimpleStrategy(1), NetworkTopologyStrategy(2))
+
 class TestNameEscaping(unittest.TestCase):
 
     def test_protect_name(self):
diff --git a/tests/unit/test_policies.py b/tests/unit/test_policies.py
@@ -55,6 +55,13 @@ def test_non_implemented(self):
         self.assertRaises(NotImplementedError, policy.on_add, host)
         self.assertRaises(NotImplementedError, policy.on_remove, host)
 
+    def test_instance_check(self):
+        try:
+            Cluster(load_balancing_policy=RoundRobinPolicy)
+            self.fail()
+        except TypeError:
+            pass
+
 
 class TestRoundRobinPolicy(unittest.TestCase):
 
diff --git a/tests/unit/test_types.py b/tests/unit/test_types.py
@@ -11,6 +11,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+import tempfile
 
 try:
     import unittest2 as unittest
@@ -22,8 +23,9 @@
 import cassandra
 from cassandra.cqltypes import (BooleanType, lookup_casstype_simple, lookup_casstype,
                                 LongType, DecimalType, SetType, cql_typename,
-                                CassandraType, UTF8Type, parse_casstype_args)
-from cassandra.decoder import named_tuple_factory
+                                CassandraType, UTF8Type, parse_casstype_args,
+                                EmptyValue, _CassandraType, DateType)
+from cassandra.decoder import named_tuple_factory, write_string, read_longstring, write_stringmap, read_stringmap, read_inet, write_inet, cql_quote
 
 
 class TypeTests(unittest.TestCase):
@@ -170,3 +172,75 @@ class BarType(FooType):
         self.assertEquals(UTF8Type, ctype.subtypes[2])
 
         self.assertEquals(['city', None, 'zip'], ctype.names)
+
+    def test_empty_value(self):
+        self.assertEqual(str(EmptyValue()), 'EMPTY')
+
+    def test_CassandraType(self):
+        cassandra_type = _CassandraType('randomvaluetocheck')
+        self.assertEqual(cassandra_type.val, 'randomvaluetocheck')
+        self.assertEqual(cassandra_type.validate('randomvaluetocheck2'), 'randomvaluetocheck2')
+        self.assertEqual(cassandra_type.val, 'randomvaluetocheck')
+
+    def test_DateType(self):
+        now = datetime.datetime.now()
+        date_type = DateType(now)
+        self.assertEqual(date_type.my_timestamp(), now)
+        try:
+            date_type.interpret_datestring('fakestring')
+            self.fail()
+        except ValueError:
+            pass
+
+    def test_write_read_string(self):
+        # BUG?
+        # Traceback (most recent call last):
+        #   File "/Users/joaquin/repos/python-driver/tests/unit/test_types.py", line 199, in test_write_read_string
+        #     self.assertEqual(read_longstring(f), u'test')
+        # AssertionError: u'st' != u'test'
+        # - st
+        # + test
+        # ? ++
+        with tempfile.TemporaryFile() as f:
+            value = u'test'
+            write_string(f, value)
+            f.seek(0)
+            self.assertEqual(read_longstring(f), value)
+
+    def test_write_read_stringmap(self):
+        with tempfile.TemporaryFile() as f:
+            value = {'key': 'value'}
+            write_stringmap(f, value)
+            f.seek(0)
+            self.assertEqual(read_stringmap(f), value)
+
+    def test_write_read_inet(self):
+        # BUG? I didn't think it mattered, but just wanted to confirm
+        # Traceback (most recent call last):
+        #   File "/Users/joaquin/repos/python-driver/tests/unit/test_types.py", line 228, in test_write_read_inet
+        #     self.assertEqual(read_inet(f), value)
+        # AssertionError: Tuples differ: ('2001:db8:0:f101::1', 9042) != ('2001:0db8:0:f101::1', 9042)
+        #
+        # First differing element 0:
+        # 2001:db8:0:f101::1
+        # 2001:0db8:0:f101::1
+        #
+        # - ('2001:db8:0:f101::1', 9042)
+        # + ('2001:0db8:0:f101::1', 9042)
+        # ?        +
+        with tempfile.TemporaryFile() as f:
+            value = ('192.168.1.1', 9042)
+            write_inet(f, value)
+            f.seek(0)
+            self.assertEqual(read_inet(f), value)
+
+        with tempfile.TemporaryFile() as f:
+            value = ('2001:0db8:0:f101::1', 9042)
+            write_inet(f, value)
+            f.seek(0)
+            self.assertEqual(read_inet(f), value)
+
+    def test_cql_quote(self):
+        self.assertEqual(cql_quote(u'test'), "'test'")
+        self.assertEqual(cql_quote('test'), "'test'")
+        self.assertEqual(cql_quote(0), '0')
