src: use FromMaybe instead of ToLocal in GetCert

danbev · danbev · commit eabe22b73371 · 2020-07-13T08:08:09.000+02:00
PR-URL: nodejs#34276 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node_crypto_common.cc b/src/node_crypto_common.cc
@@ -350,9 +350,8 @@ MaybeLocal<Value> GetCert(Environment* env, const SSLPointer& ssl) {
   if (cert == nullptr)
     return Undefined(env->isolate());
 
-  Local<Value> ret;
   MaybeLocal<Object> maybe_cert = X509ToObject(env, cert);
-  return maybe_cert.ToLocal(&ret) ? ret : MaybeLocal<Value>();
+  return maybe_cert.FromMaybe<Value>(Local<Value>());
 }
 
 namespace {

Original file line number	Diff line number	Diff line change
`@@ -350,9 +350,8 @@ MaybeLocal<Value> GetCert(Environment* env, const SSLPointer& ssl) {`
`350`	`350`	`if (cert == nullptr)`
`351`	`351`	`return Undefined(env->isolate());`
`352`	`352`
`353`		`- Local<Value> ret;`
`354`	`353`	`MaybeLocal<Object> maybe_cert = X509ToObject(env, cert);`
`355`		`- return maybe_cert.ToLocal(&ret) ? ret : MaybeLocal<Value>();`
	`354`	`+ return maybe_cert.FromMaybe<Value>(Local<Value>());`
`356`	`355`	`}`
`357`	`356`
`358`	`357`	`namespace {`