all: Use NULL instead of "" when calling mp_raise exception helpers.

dpgeorge · dpgeorge · commit f4059dcc0c52 · 2017-10-24T22:39:36.000+11:00
This is the established way of doing it and reduces code size by a little
bit.
diff --git a/extmod/modlwip.c b/extmod/modlwip.c
@@ -1032,7 +1032,7 @@ STATIC mp_obj_t lwip_socket_sendall(mp_obj_t self_in, mp_obj_t buf_in) {
             break;
         }
         case MOD_NETWORK_SOCK_DGRAM:
-            mp_raise_NotImplementedError("");
+            mp_raise_NotImplementedError(NULL);
             break;
     }
 
diff --git a/extmod/modussl_axtls.c b/extmod/modussl_axtls.c
@@ -152,7 +152,7 @@ STATIC mp_obj_t socket_setblocking(mp_obj_t self_in, mp_obj_t flag_in) {
     // Currently supports only blocking mode
     (void)self_in;
     if (!mp_obj_is_true(flag_in)) {
-        mp_raise_NotImplementedError("");
+        mp_raise_NotImplementedError(NULL);
     }
     return mp_const_none;
 }
diff --git a/extmod/modutimeq.c b/extmod/modutimeq.c
@@ -146,7 +146,7 @@ STATIC mp_obj_t mod_utimeq_heappop(mp_obj_t heap_in, mp_obj_t list_ref) {
     }
     mp_obj_list_t *ret = MP_OBJ_TO_PTR(list_ref);
     if (!MP_OBJ_IS_TYPE(list_ref, &mp_type_list) || ret->len < 3) {
-        mp_raise_TypeError("");
+        mp_raise_TypeError(NULL);
     }
 
     struct qentry *item = &heap->items[0];
diff --git a/extmod/modwebrepl.c b/extmod/modwebrepl.c
@@ -308,7 +308,7 @@ STATIC mp_obj_t webrepl_set_password(mp_obj_t passwd_in) {
     size_t len;
     const char *passwd = mp_obj_str_get_data(passwd_in, &len);
     if (len > sizeof(webrepl_passwd) - 1) {
-        mp_raise_ValueError("");
+        mp_raise_ValueError(NULL);
     }
     strcpy(webrepl_passwd, passwd);
     return mp_const_none;
diff --git a/ports/esp8266/machine_hspi.c b/ports/esp8266/machine_hspi.c
@@ -149,7 +149,7 @@ mp_obj_t machine_hspi_make_new(const mp_obj_type_t *type, size_t n_args, size_t
     // args[0] holds the id of the peripheral
     if (args[0] != MP_OBJ_NEW_SMALL_INT(1)) {
         // FlashROM is on SPI0, so far we don't support its usage
-        mp_raise_ValueError("");
+        mp_raise_ValueError(NULL);
     }
 
     machine_hspi_obj_t *self = m_new_obj(machine_hspi_obj_t);
diff --git a/ports/esp8266/machine_wdt.c b/ports/esp8266/machine_wdt.c
@@ -51,7 +51,7 @@ STATIC mp_obj_t machine_wdt_make_new(const mp_obj_type_t *type_in, size_t n_args
     case 0:
         return &wdt_default;
     default:
-        mp_raise_ValueError("");
+        mp_raise_ValueError(NULL);
     }
 }
 
diff --git a/ports/unix/modjni.c b/ports/unix/modjni.c
@@ -266,7 +266,7 @@ STATIC mp_obj_t jobject_subscr(mp_obj_t self_in, mp_obj_t index, mp_obj_t value)
                 return mp_const_none;
             }
         }
-        mp_raise_NotImplementedError("");
+        mp_raise_NotImplementedError(NULL);
     }
 
     if (!JJ(IsInstanceOf, self->obj, List_class)) {
diff --git a/py/objarray.c b/py/objarray.c
@@ -286,7 +286,7 @@ STATIC mp_obj_t array_binary_op(mp_binary_op_t op, mp_obj_t lhs_in, mp_obj_t rhs
 
             // Otherwise, can only look for a scalar numeric value in an array
             if (MP_OBJ_IS_INT(rhs_in) || mp_obj_is_float(rhs_in)) {
-                mp_raise_NotImplementedError("");
+                mp_raise_NotImplementedError(NULL);
             }
 
             return mp_const_false;
diff --git a/py/objlist.c b/py/objlist.c
@@ -158,7 +158,7 @@ STATIC mp_obj_t list_subscr(mp_obj_t self_in, mp_obj_t index, mp_obj_t value) {
             mp_obj_list_t *self = MP_OBJ_TO_PTR(self_in);
             mp_bound_slice_t slice;
             if (!mp_seq_get_fast_slice_indexes(self->len, index, &slice)) {
-                mp_raise_NotImplementedError("");
+                mp_raise_NotImplementedError(NULL);
             }
 
             mp_int_t len_adj = slice.start - slice.stop;
@@ -198,7 +198,7 @@ STATIC mp_obj_t list_subscr(mp_obj_t self_in, mp_obj_t index, mp_obj_t value) {
             mp_obj_get_array(value, &value_len, &value_items);
             mp_bound_slice_t slice_out;
             if (!mp_seq_get_fast_slice_indexes(self->len, index, &slice_out)) {
-                mp_raise_NotImplementedError("");
+                mp_raise_NotImplementedError(NULL);
             }
             mp_int_t len_adj = value_len - (slice_out.stop - slice_out.start);
             //printf("Len adj: %d\n", len_adj);

Original file line number	Diff line number	Diff line change
`@@ -1032,7 +1032,7 @@ STATIC mp_obj_t lwip_socket_sendall(mp_obj_t self_in, mp_obj_t buf_in) {`
`1032`	`1032`	`break;`
`1033`	`1033`	`}`
`1034`	`1034`	`case MOD_NETWORK_SOCK_DGRAM:`
`1035`		`- mp_raise_NotImplementedError("");`
	`1035`	`+ mp_raise_NotImplementedError(NULL);`
`1036`	`1036`	`break;`
`1037`	`1037`	`}`
`1038`	`1038`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ STATIC mp_obj_t socket_setblocking(mp_obj_t self_in, mp_obj_t flag_in) {`
`152`	`152`	`// Currently supports only blocking mode`
`153`	`153`	`(void)self_in;`
`154`	`154`	`if (!mp_obj_is_true(flag_in)) {`
`155`		`- mp_raise_NotImplementedError("");`
	`155`	`+ mp_raise_NotImplementedError(NULL);`
`156`	`156`	`}`
`157`	`157`	`return mp_const_none;`
`158`	`158`	`}`
Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ STATIC mp_obj_t mod_utimeq_heappop(mp_obj_t heap_in, mp_obj_t list_ref) {`
`146`	`146`	`}`
`147`	`147`	`mp_obj_list_t *ret = MP_OBJ_TO_PTR(list_ref);`
`148`	`148`	`if (!MP_OBJ_IS_TYPE(list_ref, &mp_type_list) \|\| ret->len < 3) {`
`149`		`- mp_raise_TypeError("");`
	`149`	`+ mp_raise_TypeError(NULL);`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`struct qentry *item = &heap->items[0];`
Original file line number	Diff line number	Diff line change
`@@ -308,7 +308,7 @@ STATIC mp_obj_t webrepl_set_password(mp_obj_t passwd_in) {`
`308`	`308`	`size_t len;`
`309`	`309`	`const char *passwd = mp_obj_str_get_data(passwd_in, &len);`
`310`	`310`	`if (len > sizeof(webrepl_passwd) - 1) {`
`311`		`- mp_raise_ValueError("");`
	`311`	`+ mp_raise_ValueError(NULL);`
`312`	`312`	`}`
`313`	`313`	`strcpy(webrepl_passwd, passwd);`
`314`	`314`	`return mp_const_none;`
Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ mp_obj_t machine_hspi_make_new(const mp_obj_type_t *type, size_t n_args, size_t`
`149`	`149`	`// args[0] holds the id of the peripheral`
`150`	`150`	`if (args[0] != MP_OBJ_NEW_SMALL_INT(1)) {`
`151`	`151`	`// FlashROM is on SPI0, so far we don't support its usage`
`152`		`- mp_raise_ValueError("");`
	`152`	`+ mp_raise_ValueError(NULL);`
`153`	`153`	`}`
`154`	`154`
`155`	`155`	`machine_hspi_obj_t *self = m_new_obj(machine_hspi_obj_t);`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ STATIC mp_obj_t machine_wdt_make_new(const mp_obj_type_t *type_in, size_t n_args`
`51`	`51`	`case 0:`
`52`	`52`	`return &wdt_default;`
`53`	`53`	`default:`
`54`		`- mp_raise_ValueError("");`
	`54`	`+ mp_raise_ValueError(NULL);`
`55`	`55`	`}`
`56`	`56`	`}`
`57`	`57`
Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,7 @@ STATIC mp_obj_t jobject_subscr(mp_obj_t self_in, mp_obj_t index, mp_obj_t value)`
`266`	`266`	`return mp_const_none;`
`267`	`267`	`}`
`268`	`268`	`}`
`269`		`- mp_raise_NotImplementedError("");`
	`269`	`+ mp_raise_NotImplementedError(NULL);`
`270`	`270`	`}`
`271`	`271`
`272`	`272`	`if (!JJ(IsInstanceOf, self->obj, List_class)) {`
Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ STATIC mp_obj_t array_binary_op(mp_binary_op_t op, mp_obj_t lhs_in, mp_obj_t rhs`
`286`	`286`
`287`	`287`	`// Otherwise, can only look for a scalar numeric value in an array`
`288`	`288`	`if (MP_OBJ_IS_INT(rhs_in) \|\| mp_obj_is_float(rhs_in)) {`
`289`		`- mp_raise_NotImplementedError("");`
	`289`	`+ mp_raise_NotImplementedError(NULL);`
`290`	`290`	`}`
`291`	`291`
`292`	`292`	`return mp_const_false;`