Skip to content

Commit da1fffa

Browse files
committed
Fix some unused variables, and silence a clang warning about initialization override in vmentrytable.h
1 parent ceac71f commit da1fffa

File tree

4 files changed

+16
-4
lines changed

4 files changed

+16
-4
lines changed

py/modmath.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ STATIC const mp_map_elem_t mp_module_math_globals_table[] = {
151151
{ MP_OBJ_NEW_QSTR(MP_QSTR_copysign), (mp_obj_t)&mp_math_copysign_obj },
152152
{ MP_OBJ_NEW_QSTR(MP_QSTR_fabs), (mp_obj_t)&mp_math_fabs_obj },
153153
{ MP_OBJ_NEW_QSTR(MP_QSTR_floor), (mp_obj_t)&mp_math_floor_obj },
154+
{ MP_OBJ_NEW_QSTR(MP_QSTR_fmod), (mp_obj_t)&mp_math_fmod_obj },
154155
{ MP_OBJ_NEW_QSTR(MP_QSTR_frexp), (mp_obj_t)&mp_math_frexp_obj },
155156
{ MP_OBJ_NEW_QSTR(MP_QSTR_ldexp), (mp_obj_t)&mp_math_ldexp_obj },
156157
{ MP_OBJ_NEW_QSTR(MP_QSTR_modf), (mp_obj_t)&mp_math_modf_obj },

py/objexcept.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,11 +168,13 @@ MP_DEFINE_EXCEPTION(Exception, BaseException)
168168
MP_DEFINE_EXCEPTION(KeyError, LookupError)
169169
MP_DEFINE_EXCEPTION(MemoryError, Exception)
170170
MP_DEFINE_EXCEPTION(NameError, Exception)
171+
/*
171172
MP_DEFINE_EXCEPTION_BASE(NameError)
172-
//MP_DEFINE_EXCEPTION(UnboundLocalError, NameError)
173+
MP_DEFINE_EXCEPTION(UnboundLocalError, NameError)
174+
*/
173175
MP_DEFINE_EXCEPTION(OSError, Exception)
174-
MP_DEFINE_EXCEPTION_BASE(OSError)
175176
/*
177+
MP_DEFINE_EXCEPTION_BASE(OSError)
176178
MP_DEFINE_EXCEPTION(BlockingIOError, OSError)
177179
MP_DEFINE_EXCEPTION(ChildProcessError, OSError)
178180
MP_DEFINE_EXCEPTION(ConnectionError, OSError)

py/vmentrytable.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@
2424
* THE SOFTWARE.
2525
*/
2626

27+
#if __clang__
28+
#pragma clang diagnostic push
29+
#pragma clang diagnostic ignored "-Winitializer-overrides"
30+
#endif // __clang__
31+
2732
static void* entry_table[256] = {
2833
[0 ... 255] = &&entry_default,
2934
[MP_BC_LOAD_CONST_FALSE] = &&entry_MP_BC_LOAD_CONST_FALSE,
@@ -110,3 +115,7 @@ static void* entry_table[256] = {
110115
[MP_BC_IMPORT_FROM] = &&entry_MP_BC_IMPORT_FROM,
111116
[MP_BC_IMPORT_STAR] = &&entry_MP_BC_IMPORT_STAR,
112117
};
118+
119+
#if __clang__
120+
#pragma clang diagnostic pop
121+
#endif // __clang__

unix/modsocket.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,7 @@ STATIC const mp_obj_type_t microsocket_type = {
291291
.locals_dict = (mp_obj_t)&microsocket_locals_dict,
292292
};
293293

294+
#if MICROPY_SOCKET_EXTRA
294295
STATIC mp_obj_t mod_socket_htons(mp_obj_t arg) {
295296
return MP_OBJ_NEW_SMALL_INT((machine_int_t)htons(MP_OBJ_SMALL_INT_VALUE(arg)));
296297
}
@@ -308,7 +309,6 @@ STATIC mp_obj_t mod_socket_inet_aton(mp_obj_t arg) {
308309
}
309310
STATIC MP_DEFINE_CONST_FUN_OBJ_1(mod_socket_inet_aton_obj, mod_socket_inet_aton);
310311

311-
#if MICROPY_SOCKET_EXTRA
312312
STATIC mp_obj_t mod_socket_gethostbyname(mp_obj_t arg) {
313313
assert(MP_OBJ_IS_TYPE(arg, &mp_type_str));
314314
const char *s = mp_obj_str_get_str(arg);
@@ -321,7 +321,7 @@ STATIC mp_obj_t mod_socket_gethostbyname(mp_obj_t arg) {
321321
return mp_obj_new_int(*(int*)*h->h_addr_list);
322322
}
323323
STATIC MP_DEFINE_CONST_FUN_OBJ_1(mod_socket_gethostbyname_obj, mod_socket_gethostbyname);
324-
#endif
324+
#endif // MICROPY_SOCKET_EXTRA
325325

326326
STATIC mp_obj_t mod_socket_getaddrinfo(uint n_args, const mp_obj_t *args) {
327327
// TODO: Implement all args

0 commit comments

Comments
 (0)