py: mp_buffer_info_t::buf may be valid, but NULL for empty objects.

pfalcon · pfalcon · commit 7133d9177339 · 2014-08-10T16:22:48.000+03:00
This happens for example for zero-size arrays. As .get_buffer() method now
has explicit return value, it's enough to distinguish success vs failure
of getting buffer.
diff --git a/py/obj.c b/py/obj.c
@@ -410,7 +410,7 @@ bool mp_get_buffer(mp_obj_t obj, mp_buffer_info_t *bufinfo, int flags) {
         return false;
     }
     int ret = type->buffer_p.get_buffer(obj, bufinfo, flags);
-    if (ret != 0 || bufinfo->buf == NULL) {
+    if (ret != 0) {
         return false;
     }
     return true;
diff --git a/py/obj.h b/py/obj.h
@@ -210,7 +210,7 @@ typedef struct _mp_buffer_info_t {
     // them with ver = sizeof(struct). Cons: overkill for *micro*?
     //int ver; // ?
 
-    void *buf;
+    void *buf;    // can be NULL if len == 0
     mp_int_t len; // in bytes
     int typecode; // as per binary.h
 

Original file line number	Diff line number	Diff line change
`@@ -410,7 +410,7 @@ bool mp_get_buffer(mp_obj_t obj, mp_buffer_info_t *bufinfo, int flags) {`
`410`	`410`	`return false;`
`411`	`411`	`}`
`412`	`412`	`int ret = type->buffer_p.get_buffer(obj, bufinfo, flags);`
`413`		`- if (ret != 0 \|\| bufinfo->buf == NULL) {`
	`413`	`+ if (ret != 0) {`
`414`	`414`	`return false;`
`415`	`415`	`}`
`416`	`416`	`return true;`