Fix infinity loop with negative numbers (trekhleb#502)

onicat · web-flow · commit be185ac9afab · 2020-08-21T07:21:20.000+02:00
* Update countSetBits.js

* Update countSetBits.test.js
diff --git a/src/algorithms/math/bits/__test__/countSetBits.test.js b/src/algorithms/math/bits/__test__/countSetBits.test.js
@@ -11,5 +11,9 @@ describe('countSetBits', () => {
     expect(countSetBits(21)).toBe(3);
     expect(countSetBits(255)).toBe(8);
     expect(countSetBits(1023)).toBe(10);
+    expect(countSetBits(-1)).toBe(32);
+    expect(countSetBits(-21)).toBe(30);
+    expect(countSetBits(-255)).toBe(25);
+    expect(countSetBits(-1023)).toBe(23);
   });
 });
diff --git a/src/algorithms/math/bits/countSetBits.js b/src/algorithms/math/bits/countSetBits.js
@@ -11,7 +11,7 @@ export default function countSetBits(originalNumber) {
     setBitsCount += number & 1;
 
     // Shift number right by one bit to investigate other bits.
-    number >>= 1;
+    number >>>= 1;
   }
 
   return setBitsCount;

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ export default function countSetBits(originalNumber) {`
`11`	`11`	`setBitsCount += number & 1;`
`12`	`12`
`13`	`13`	`// Shift number right by one bit to investigate other bits.`
`14`		`- number >>= 1;`
	`14`	`+ number >>>= 1;`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`return setBitsCount;`