Add column offset to fix mypy linter pointing to wrong column number (off by one) (microsoft#15505)

anttipessa · web-flow · commit fe94dda7b3a6 · 2021-03-05T10:29:18.000-08:00
* Fix mypy column offset off by one

* Add news item

* Fix unit test

* Update the expected output
diff --git a/news/2 Fixes/14978.md b/news/2 Fixes/14978.md
@@ -0,0 +1 @@
+Fix Mypy linter pointing to wrong column number (off by one). (thanks [anttipessa](https://github.com/anttipessa/), [haalto](https://github.com/haalto/), [JeonCD](https://github.com/JeonCD/) and [junskU](https://github.com/junskU))
diff --git a/src/client/linters/mypy.ts b/src/client/linters/mypy.ts
@@ -6,10 +6,11 @@ import { BaseLinter } from './baseLinter';
 import { ILintMessage } from './types';
 
 export const REGEX = '(?<file>[^:]+):(?<line>\\d+)(:(?<column>\\d+))?: (?<type>\\w+): (?<message>.*)\\r?(\\n|$)';
+const COLUMN_OFF_SET = 1;
 
 export class MyPy extends BaseLinter {
     constructor(outputChannel: OutputChannel, serviceContainer: IServiceContainer) {
-        super(Product.mypy, outputChannel, serviceContainer);
+        super(Product.mypy, outputChannel, serviceContainer, COLUMN_OFF_SET);
     }
 
     protected async runLinter(document: TextDocument, cancellation: CancellationToken): Promise<ILintMessage[]> {
diff --git a/src/test/linters/mypy.unit.test.ts b/src/test/linters/mypy.unit.test.ts
@@ -47,15 +47,15 @@ suite('Linting - MyPy', () => {
                 {
                     code: undefined,
                     message: 'Expression has type "Any"',
-                    column: 21,
+                    column: 20,
                     line: 12,
                     type: 'error',
                     provider: 'mypy',
                 } as ILintMessage,
             ],
         ];
         for (const [line, expected] of tests) {
-            const msg = parseLine(line, REGEX, LinterId.MyPy);
+            const msg = parseLine(line, REGEX, LinterId.MyPy, 1);
 
             expect(msg).to.deep.equal(expected);
         }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix Mypy linter pointing to wrong column number (off by one). (thanks [anttipessa](https://github.com/anttipessa/), [haalto](https://github.com/haalto/), [JeonCD](https://github.com/JeonCD/) and [junskU](https://github.com/junskU))`