Skip to content

Commit d832703

Browse files
committed
Backported from the trunk:
- When doing a frameworkinstall test whether Apple's Python 2.3 may need fixing - Added quotes around destroot arguments.
1 parent 4d031e5 commit d832703

1 file changed

Lines changed: 16 additions & 9 deletions

File tree

Mac/OSX/Makefile

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# main Makefile. The next couple of variables are overridden on the
33
# commandline in that case.
44

5-
VERSION=2.5
5+
VERSION=2.4
66
builddir = ../..
77
srcdir = ../..
88
prefix=/Library/Frameworks/Python.framework/Versions/$(VERSION)
@@ -60,7 +60,7 @@ compileall=$(srcdir)/Lib/compileall.py
6060
bundlebuilder=$(srcdir)/Lib/plat-mac/bundlebuilder.py
6161

6262
installapps: install_PythonLauncher install_Python install_BuildApplet install_IDE \
63-
install_IDLE install_PackageManager
63+
install_IDLE install_PackageManager checkapplepython
6464

6565
install_PythonLauncher:
6666
cd $(srcdir)/Mac/OSX/PythonLauncher/PythonLauncher.pbproj ; \
@@ -120,12 +120,12 @@ install_IDE:
120120
echo See Mac/OSX/README for details; \
121121
else \
122122
echo $(BUILDPYTHON) $(srcdir)/Mac/scripts/BuildApplet.py \
123-
--destroot $(DESTDIR) \
123+
--destroot "$(DESTDIR)" \
124124
--python $(INSTALLED_PYTHONW) \
125125
--output $(DESTDIR)$(PYTHONAPPSDIR)/PythonIDE.app --noargv \
126126
$(srcdir)/Mac/Tools/IDE/PythonIDE.py ; \
127127
$(BUILDPYTHON) $(srcdir)/Mac/scripts/BuildApplet.py \
128-
--destroot $(DESTDIR) \
128+
--destroot "$(DESTDIR)" \
129129
--python $(INSTALLED_PYTHONW) \
130130
--output $(DESTDIR)$(PYTHONAPPSDIR)/PythonIDE.app --noargv \
131131
$(srcdir)/Mac/Tools/IDE/PythonIDE.py; \
@@ -138,15 +138,15 @@ install_PackageManager:
138138
else \
139139
echo $(BUILDPYTHON) $(bundlebuilder) \
140140
--builddir $(DESTDIR)$(PYTHONAPPSDIR)/ \
141-
--destroot $(DESTDIR) \
141+
--destroot "$(DESTDIR)" \
142142
--python $(INSTALLED_PYTHONW) \
143143
--resource $(srcdir)/Mac/Tools/IDE/PythonIDE.rsrc \
144144
--mainprogram $(srcdir)/Mac/Tools/IDE/PackageManager.py \
145145
--iconfile $(srcdir)/Mac/Tools/IDE/PackageManager.icns \
146146
--creator Pimp build; \
147147
$(BUILDPYTHON) $(bundlebuilder) \
148148
--builddir $(DESTDIR)$(PYTHONAPPSDIR)/ \
149-
--destroot $(DESTDIR) \
149+
--destroot "$(DESTDIR)" \
150150
--python $(INSTALLED_PYTHONW) \
151151
--resource $(srcdir)/Mac/Tools/IDE/PythonIDE.rsrc \
152152
--mainprogram $(srcdir)/Mac/Tools/IDE/PackageManager.py \
@@ -161,13 +161,13 @@ install_IDLE:
161161
else \
162162
echo $(BUILDPYTHON) $(srcdir)/Mac/scripts/BuildApplet.py \
163163
--python $(INSTALLED_PYTHONW) \
164-
--destroot $(DESTDIR) \
164+
--destroot "$(DESTDIR)" \
165165
--output $(DESTDIR)$(PYTHONAPPSDIR)/IDLE.app \
166166
--extra $(srcdir)/Lib/idlelib \
167167
$(srcdir)/Tools/scripts/idle ; \
168168
$(BUILDPYTHON) $(srcdir)/Mac/scripts/BuildApplet.py \
169169
--python $(INSTALLED_PYTHONW) \
170-
--destroot $(DESTDIR) \
170+
--destroot "$(DESTDIR)" \
171171
--output $(DESTDIR)$(PYTHONAPPSDIR)/IDLE.app \
172172
--extra $(srcdir)/Lib/idlelib:Contents/Resources/idlelib \
173173
$(srcdir)/Tools/scripts/idle ; \
@@ -176,7 +176,7 @@ install_IDLE:
176176

177177
install_BuildApplet:
178178
$(BUILDPYTHON) $(srcdir)/Mac/scripts/BuildApplet.py \
179-
--destroot $(DESTDIR) \
179+
--destroot "$(DESTDIR)" \
180180
--python $(INSTALLED_PYTHONW) \
181181
--output $(DESTDIR)$(PYTHONAPPSDIR)/BuildApplet.app \
182182
$(srcdir)/Mac/scripts/BuildApplet.py
@@ -264,3 +264,10 @@ installextras:
264264
$(DESTDIR)$(PYTHONAPPSDIR)/Extras/Demo
265265
$(BUILDPYTHON) $(srcdir)/Mac/OSX/Extras.install.py $(srcdir)/Tools \
266266
$(DESTDIR)$(PYTHONAPPSDIR)/Extras/Tools
267+
268+
checkapplepython:
269+
@if ! $(BUILDPYTHON) $(srcdir)/Mac/OSX/fixapplepython23.py -n; then \
270+
echo "* WARNING: Apple-installed Python 2.3 will have trouble building extensions from now on."; \
271+
echo "* WARNING: Run $(srcdir)/Mac/OSX/fixapplepython23.py with \"sudo\" to fix this."; \
272+
fi
273+

0 commit comments

Comments
 (0)