Backport: This should fix a mem leak on the Mac. Brett tested it.

nnorwitz · nnorwitz · commit c280d940347b · 2006-01-23T07:37:28.000Z
diff --git a/Mac/Modules/file/_Filemodule.c b/Mac/Modules/file/_Filemodule.c
@@ -3202,9 +3202,9 @@ PyMac_GetFSRef(PyObject *v, FSRef *fsr)
 			return NULL;
 		if ( (err=FSPathMakeRef(path, fsr, NULL)) ) {
 			PyMac_Error(err);
-			return 0;
 		}
-		return 1;
+		PyMem_Free(path);
+		return !err;
 	}
 	/* XXXX Should try unicode here too */
 	/* Otherwise we try to go via an FSSpec */

Original file line number	Diff line number	Diff line change
`@@ -3202,9 +3202,9 @@ PyMac_GetFSRef(PyObject v, FSRef fsr)`
`3202`	`3202`	`return NULL;`
`3203`	`3203`	`if ( (err=FSPathMakeRef(path, fsr, NULL)) ) {`
`3204`	`3204`	`PyMac_Error(err);`
`3205`		`- return 0;`
`3206`	`3205`	`}`
`3207`		`- return 1;`
	`3206`	`+ PyMem_Free(path);`
	`3207`	`+ return !err;`
`3208`	`3208`	`}`
`3209`	`3209`	`/* XXXX Should try unicode here too */`
`3210`	`3210`	`/* Otherwise we try to go via an FSSpec */`