Add test for failure of the getattr call in pcre_expand() -- it used

gvanrossum · gvanrossum · commit 1a7855309322 · 1998-07-17T20:19:48.000Z
to core dump if the first argument did not have a "group" attribute.
diff --git a/Modules/pcremodule.c b/Modules/pcremodule.c
@@ -512,6 +512,10 @@ PyPcre_expand(self, args)
 			{
 				PyObject *r, *tuple, *result;
 				r=PyObject_GetAttrString(match_obj, "group");
+				if (r == NULL) {
+					Py_DECREF(results);
+					return NULL;
+				}
 				tuple=PyTuple_New(1);
 				Py_INCREF(value);
 				PyTuple_SetItem(tuple, 0, value);
