Issue python#24098: Fixed possible crash when AST is changed in process of

serhiy-storchaka · serhiy-storchaka · commit cf3806026b4f · 2016-10-07T21:51:28.000+03:00
compiling it.
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -10,6 +10,9 @@ Release date: TBA
 Core and Builtins
 -----------------
 
+- Issue #24098: Fixed possible crash when AST is changed in process of
+  compiling it.
+
 - Issue #28350: String constants with null character no longer interned.
 
 - Issue #26617: Fix crash when GC runs during weakref callbacks.
diff --git a/Parser/asdl_c.py b/Parser/asdl_c.py
@@ -526,6 +526,13 @@ def visitField(self, field, name, sum=None, prod=None, depth=0):
             self.emit("res = obj2ast_%s(PyList_GET_ITEM(tmp, i), &value, arena);" %
                       field.type, depth+2, reflow=False)
             self.emit("if (res != 0) goto failed;", depth+2)
+            self.emit("if (len != PyList_GET_SIZE(tmp)) {", depth+2)
+            self.emit("PyErr_SetString(PyExc_RuntimeError, \"%s field \\\"%s\\\" "
+                      "changed size during iteration\");" %
+                      (name, field.name),
+                      depth+3, reflow=False)
+            self.emit("goto failed;", depth+3)
+            self.emit("}", depth+2)
             self.emit("asdl_seq_SET(%s, i, value);" % field.name, depth+2)
             self.emit("}", depth+1)
         else:
diff --git a/Python/Python-ast.c b/Python/Python-ast.c
