Merge pull request hardbyte#869 from hardbyte/neovi-serial-decode-range

mergify[bot] · web-flow · commit 71b4c629a865 · 2020-07-24T08:42:42.000Z
Simplified the serial number decode conditions
diff --git a/can/interfaces/ics_neovi/neovi_bus.py b/can/interfaces/ics_neovi/neovi_bus.py
@@ -212,10 +212,10 @@ def get_serial_number(device):
         :return: ics device serial string
         :rtype: str
         """
-        a0000 = 604661760
-        if device.SerialNumber >= a0000:
+        if int("AA0000", 36) < device.SerialNumber < int("ZZZZZZ", 36):
             return ics.base36enc(device.SerialNumber)
-        return str(device.SerialNumber)
+        else:
+            return str(device.SerialNumber)
 
     def shutdown(self):
         super().shutdown()
