src: refactor Reallocate since it introduced in upstream v8

gengjiawen · gengjiawen · commit 4ad26923f480 · 2020-05-14T14:37:58.000Z
PR-URL: nodejs#33402 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/src/node_internals.h b/src/node_internals.h
@@ -112,7 +112,7 @@ class NodeArrayBufferAllocator : public ArrayBufferAllocator {
   void* Allocate(size_t size) override;  // Defined in src/node.cc
   void* AllocateUninitialized(size_t size) override;
   void Free(void* data, size_t size) override;
-  virtual void* Reallocate(void* data, size_t old_size, size_t size);
+  void* Reallocate(void* data, size_t old_size, size_t size) override;
   virtual void RegisterPointer(void* data, size_t size) {
     total_mem_usage_.fetch_add(size, std::memory_order_relaxed);
   }

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ class NodeArrayBufferAllocator : public ArrayBufferAllocator {`
`112`	`112`	`void* Allocate(size_t size) override; // Defined in src/node.cc`
`113`	`113`	`void* AllocateUninitialized(size_t size) override;`
`114`	`114`	`void Free(void* data, size_t size) override;`
`115`		`- virtual void* Reallocate(void* data, size_t old_size, size_t size);`
	`115`	`+ void* Reallocate(void* data, size_t old_size, size_t size) override;`
`116`	`116`	`virtual void RegisterPointer(void* data, size_t size) {`
`117`	`117`	`total_mem_usage_.fetch_add(size, std::memory_order_relaxed);`
`118`	`118`	`}`