module: remove unused code in module.js

Trott · Trott · commit 3b9cc424a424 · 2018-02-15T16:20:44.000-08:00
Remove unnecessary condition in lib/module.js. Refs: nodejs#18593 (comment) PR-URL: nodejs#18768 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
diff --git a/lib/module.js b/lib/module.js
@@ -128,9 +128,6 @@ function readPackage(requestPath) {
     return false;
   }
 
-  if (json === '')
-    return packageMainCache[requestPath] = undefined;
-
   try {
     var pkg = packageMainCache[requestPath] = JSON.parse(json).main;
   } catch (e) {

Original file line number	Diff line number	Diff line change
`@@ -128,9 +128,6 @@ function readPackage(requestPath) {`
`128`	`128`	`return false;`
`129`	`129`	`}`
`130`	`130`
`131`		`- if (json === '')`
`132`		`- return packageMainCache[requestPath] = undefined;`
`133`		`-`
`134`	`131`	`try {`
`135`	`132`	`var pkg = packageMainCache[requestPath] = JSON.parse(json).main;`
`136`	`133`	`} catch (e) {`