Chore: Refactoring

BornToBeRoot · BornToBeRoot · commit ca64318439cf · 2023-06-04T17:33:57.000+02:00
diff --git a/Source/NETworkManager.Converters/RemoteDesktopKeyboardHookModeToStringConverter.cs b/Source/NETworkManager.Converters/RemoteDesktopKeyboardHookModeToStringConverter.cs
@@ -21,7 +21,7 @@ public sealed class RemoteDesktopKeyboardHookModeToStringConverter : IValueConve
     /// <returns>Translated <see cref="KeyboardHookMode"/>.</returns>
     public object Convert(object value, Type targetType, object parameter, CultureInfo culture)
     {
-        if (!(value is KeyboardHookMode keyboardHookMode))
+        if (value is not KeyboardHookMode keyboardHookMode)
             return "-/-";
 
         return RemoteDesktopKeyboardHookModeTranslator.GetInstance().Translate(keyboardHookMode);                        
diff --git a/Source/NETworkManager.Settings/SettingsInfo.cs b/Source/NETworkManager.Settings/SettingsInfo.cs
@@ -54,7 +54,7 @@ public string Version
     }
 
     #region General 
-    // General        
+    // General
     private ApplicationName _general_DefaultApplicationViewName = GlobalStaticConfiguration.General_DefaultApplicationViewName;
     public ApplicationName General_DefaultApplicationViewName
     {
@@ -3207,7 +3207,7 @@ public ObservableCollection<string> SNMP_OIDHistory
             SettingsChanged = true;
         }
     }
-    
+
     private ObservableCollection<SNMPOIDProfileInfo> _snmp_OIDProfiles = new();
     public ObservableCollection<SNMPOIDProfileInfo> SNMP_OIDProfiles
     {
@@ -3222,7 +3222,7 @@ public ObservableCollection<SNMPOIDProfileInfo> SNMP_OIDProfiles
             SettingsChanged = true;
         }
     }
-    
+
     private int _snmp_Timeout = GlobalStaticConfiguration.SNMP_Timeout;
     public int SNMP_Timeout
     {
@@ -3252,7 +3252,7 @@ public WalkMode SNMP_WalkMode
             SettingsChanged = true;
         }
     }
-    
+
     private int _snmp_port = 161;
     public int SNMP_Port
     {
@@ -3267,7 +3267,7 @@ public int SNMP_Port
             SettingsChanged = true;
         }
     }
-    
+
     private SNMPMode _snmp_Mode = GlobalStaticConfiguration.SNMP_Mode;
     public SNMPMode SNMP_Mode
     {
@@ -3373,7 +3373,7 @@ public double SNMP_ProfileWidth
         }
     }
 
-    
+
     private string _snmp_ExportFilePath;
     public string SNMP_ExportFilePath
     {
diff --git a/Source/NETworkManager/ViewModels/SettingsGeneralViewModel.cs b/Source/NETworkManager/ViewModels/SettingsGeneralViewModel.cs
@@ -205,7 +205,7 @@ public ICommand VisibleToHideApplicationCommand
 
     private void VisibleToHideApplicationAction()
     {        
-        var newDefaultApplication = DefaultApplicationSelectedItem.Name == VisibleApplicationSelectedItem.Name;
+        var selectNewDefaultApplication = DefaultApplicationSelectedItem.Name == VisibleApplicationSelectedItem.Name;
 
         // Remove and add will fire a collection changed event --> detected in MainWindow
         var info = SettingsManager.Current.General_ApplicationList.First(x => VisibleApplicationSelectedItem.Name.Equals(x.Name));
@@ -215,7 +215,7 @@ private void VisibleToHideApplicationAction()
         SettingsManager.Current.General_ApplicationList.Remove(info);
         SettingsManager.Current.General_ApplicationList.Add(info);
 
-        if (newDefaultApplication)
+        if (selectNewDefaultApplication)
             DefaultApplicationSelectedItem = ApplicationsVisible.Cast<ApplicationInfo>().FirstOrDefault();
 
         ValidateHideVisibleApplications();

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public sealed class RemoteDesktopKeyboardHookModeToStringConverter : IValueConve`
`21`	`21`	`/// <returns>Translated <see cref="KeyboardHookMode"/>.</returns>`
`22`	`22`	`public object Convert(object value, Type targetType, object parameter, CultureInfo culture)`
`23`	`23`	`{`
`24`		`- if (!(value is KeyboardHookMode keyboardHookMode))`
	`24`	`+ if (value is not KeyboardHookMode keyboardHookMode)`
`25`	`25`	`return "-/-";`
`26`	`26`
`27`	`27`	`return RemoteDesktopKeyboardHookModeTranslator.GetInstance().Translate(keyboardHookMode);`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public string Version`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`#region General`
`57`		`- // General`
	`57`	`+ // General`
`58`	`58`	`private ApplicationName _general_DefaultApplicationViewName = GlobalStaticConfiguration.General_DefaultApplicationViewName;`
`59`	`59`	`public ApplicationName General_DefaultApplicationViewName`
`60`	`60`	`{`
`@@ -3207,7 +3207,7 @@ public ObservableCollection<string> SNMP_OIDHistory`
`3207`	`3207`	`SettingsChanged = true;`
`3208`	`3208`	`}`
`3209`	`3209`	`}`
`3210`		`-`
	`3210`	`+`
`3211`	`3211`	`private ObservableCollection<SNMPOIDProfileInfo> _snmp_OIDProfiles = new();`
`3212`	`3212`	`public ObservableCollection<SNMPOIDProfileInfo> SNMP_OIDProfiles`
`3213`	`3213`	`{`
`@@ -3222,7 +3222,7 @@ public ObservableCollection<SNMPOIDProfileInfo> SNMP_OIDProfiles`
`3222`	`3222`	`SettingsChanged = true;`
`3223`	`3223`	`}`
`3224`	`3224`	`}`
`3225`		`-`
	`3225`	`+`
`3226`	`3226`	`private int _snmp_Timeout = GlobalStaticConfiguration.SNMP_Timeout;`
`3227`	`3227`	`public int SNMP_Timeout`
`3228`	`3228`	`{`
`@@ -3252,7 +3252,7 @@ public WalkMode SNMP_WalkMode`
`3252`	`3252`	`SettingsChanged = true;`
`3253`	`3253`	`}`
`3254`	`3254`	`}`
`3255`		`-`
	`3255`	`+`
`3256`	`3256`	`private int _snmp_port = 161;`
`3257`	`3257`	`public int SNMP_Port`
`3258`	`3258`	`{`
`@@ -3267,7 +3267,7 @@ public int SNMP_Port`
`3267`	`3267`	`SettingsChanged = true;`
`3268`	`3268`	`}`
`3269`	`3269`	`}`
`3270`		`-`
	`3270`	`+`
`3271`	`3271`	`private SNMPMode _snmp_Mode = GlobalStaticConfiguration.SNMP_Mode;`
`3272`	`3272`	`public SNMPMode SNMP_Mode`
`3273`	`3273`	`{`
`@@ -3373,7 +3373,7 @@ public double SNMP_ProfileWidth`
`3373`	`3373`	`}`
`3374`	`3374`	`}`
`3375`	`3375`
`3376`		`-`
	`3376`	`+`
`3377`	`3377`	`private string _snmp_ExportFilePath;`
`3378`	`3378`	`public string SNMP_ExportFilePath`
`3379`	`3379`	`{`