Passed deleteOptions to deleteNamespacedCustomObject and expand delete testcase to check for url verify

callingmahendra · callingmahendra · commit 31addf432f58 · 2024-07-17T15:51:25.000+05:30
diff --git a/extended/src/main/java/io/kubernetes/client/extended/kubectl/KubectlDelete.java b/extended/src/main/java/io/kubernetes/client/extended/kubectl/KubectlDelete.java
@@ -80,6 +80,6 @@ private void verifyArguments() throws KubectlException {
     if (null == name) {
       throw new KubectlException("missing name argument");
     }
-    
+
   }
 }
diff --git a/extended/src/test/java/io/kubernetes/client/extended/kubectl/KubectlDeleteTest.java b/extended/src/test/java/io/kubernetes/client/extended/kubectl/KubectlDeleteTest.java
@@ -213,7 +213,10 @@ void kubectlDelete() throws KubectlException, ApiException {
         deleteOptions.setPropagationPolicy("Foreground");
         kubectlDelete.deleteOptions(deleteOptions);
         kubectlDelete.execute();
-
+        apiServer.verify(
+            1,
+            deleteRequestedFor(urlPathEqualTo("/apis/batch%2Fv1/batch%2Fv1/namespaces/foo/jobs/bar"))
+                .withRequestBody(equalToJson("{\"propagationPolicy\" : \"Foreground\"}")));
         assertThatThrownBy(() -> {
             KubectlDelete<V1Job> kubectlDelete2 = Kubectl.delete(V1Job.class);
             kubectlDelete2.apiClient(apiClient);
diff --git a/util/src/main/java/io/kubernetes/client/util/generic/GenericKubernetesApi.java b/util/src/main/java/io/kubernetes/client/util/generic/GenericKubernetesApi.java
@@ -1159,6 +1159,7 @@ private CallBuilder makeNamespacedDeleteCallBuilder(
             namespace,
             this.resourcePlural,
             name)
+                .body(deleteOptions)
                 // TODO: fill/convert the option
                 .buildCall(null);
   }

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,6 @@ private void verifyArguments() throws KubectlException {`
`80`	`80`	`if (null == name) {`
`81`	`81`	`throw new KubectlException("missing name argument");`
`82`	`82`	`}`
`83`		`-`
	`83`	`+`
`84`	`84`	`}`
`85`	`85`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1159,6 +1159,7 @@ private CallBuilder makeNamespacedDeleteCallBuilder(`
`1159`	`1159`	`namespace,`
`1160`	`1160`	`this.resourcePlural,`
`1161`	`1161`	`name)`
	`1162`	`+ .body(deleteOptions)`
`1162`	`1163`	`// TODO: fill/convert the option`
`1163`	`1164`	`.buildCall(null);`
`1164`	`1165`	`}`