bpo-41336: Fix the error handling in zoneinfo_new_instance() (pythonGH-21546)

ZackerySpytz · web-flow · commit eca2549f5a50 · 2020-07-20T15:51:26.000+03:00
Do not call PyObject_CallMethod() with a live exception (like
KeyboardInterrupt).
diff --git a/Modules/_zoneinfo.c b/Modules/_zoneinfo.c
@@ -224,8 +224,14 @@ zoneinfo_new_instance(PyTypeObject *type, PyObject *key)
     self = NULL;
 cleanup:
     if (file_obj != NULL) {
+        PyObject *exc, *val, *tb;
+        PyErr_Fetch(&exc, &val, &tb);
         PyObject *tmp = PyObject_CallMethod(file_obj, "close", NULL);
-        Py_DECREF(tmp);
+        _PyErr_ChainExceptions(exc, val, tb);
+        if (tmp == NULL) {
+            Py_CLEAR(self);
+        }
+        Py_XDECREF(tmp);
         Py_DECREF(file_obj);
     }
     Py_DECREF(file_path);
