From ccb2df3b10571835feedb8c68f284312fc98ebad Mon Sep 17 00:00:00 2001 From: Teppo Malinen Date: Mon, 19 Jan 2015 13:03:48 +0200 Subject: [PATCH 1/2] Fix for file download issues on Linux and Macs --- CHANGELOG | 3 +++ setup.py | 2 +- testdroid/__init__.py | 9 +++++++-- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 41659bf..e2095c1 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,3 +1,6 @@ +0.1.8 +* Fix file download for Linux and Mac machines. + 0.1.7 * Add pillow to required dependencies * Fix pillow Image import diff --git a/setup.py b/setup.py index c33fd2f..6b0375c 100644 --- a/setup.py +++ b/setup.py @@ -2,7 +2,7 @@ from setuptools import setup, find_packages import sys, os -version = '0.1.7' +version = '0.1.8' setup(name='testdroid', version=version, diff --git a/testdroid/__init__.py b/testdroid/__init__.py index b988a9e..caa752f 100755 --- a/testdroid/__init__.py +++ b/testdroid/__init__.py @@ -8,7 +8,7 @@ from datetime import datetime FORMAT = '%(message)s' -__version__ = '0.1.7' +__version__ = '0.1.8' logging.basicConfig(format=FORMAT) logger = logging.getLogger('testdroid') logger.setLevel(logging.INFO) @@ -172,7 +172,12 @@ def download(self, path=None, filename=None, payload={}, callback=None): pos = 0 total = res.headers['content-length'] - fd = os.open(filename, os.O_RDWR|os.O_CREAT|os.O_BINARY) + # Check if the system is Windows or not. + if os.name == nt: + fd = os.open(filename, os.O_RDWR|os.O_CREAT|os.O_BINARY) + else: + fd = os.open(filename, os.O_RDWR|os.O_CREAT) + for chunk in res.iter_content(self.download_buffer_size): os.write(fd, chunk) if callback: From a096264207e3fabb68215b24aa4154d311ae73cb Mon Sep 17 00:00:00 2001 From: Teppo Malinen Date: Mon, 19 Jan 2015 13:03:48 +0200 Subject: [PATCH 2/2] Fix for file download issues on Linux and Macs --- testdroid/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testdroid/__init__.py b/testdroid/__init__.py index caa752f..d701ec9 100755 --- a/testdroid/__init__.py +++ b/testdroid/__init__.py @@ -173,7 +173,7 @@ def download(self, path=None, filename=None, payload={}, callback=None): total = res.headers['content-length'] # Check if the system is Windows or not. - if os.name == nt: + if os.name == 'nt': fd = os.open(filename, os.O_RDWR|os.O_CREAT|os.O_BINARY) else: fd = os.open(filename, os.O_RDWR|os.O_CREAT)